Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1226473002: Add LayoutTests for mixed range response handling. (Closed)

Created:
5 years, 5 months ago by horo
Modified:
5 years, 5 months ago
Reviewers:
falken, hubbe, DaleCurtis
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add LayoutTests for mixed range response handling. This CL adds three tests: - media/mixed-range-response.html - serviceworker/chromium/service-worker-generated-mixed-response.html - serviceworker/chromium/service-worker-proxied-mixed-response.html This cl must be submitted after chromium side patch https://codereview.chromium.org/1220963004/. BUG=505829 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199001

Patch Set 1 : #

Total comments: 18

Patch Set 2 : incorporated falken's comment and refactored #

Total comments: 16

Patch Set 3 : incorporated falken's comment #

Patch Set 4 : incorporated hubbe's comment in https://codereview.chromium.org/1220963004#msg27 #

Total comments: 2

Patch Set 5 : third #

Messages

Total messages: 22 (10 generated)
horo
hubbe@ Could you please review LayoutTests/http/tests/media/*? falken@ Could you please reveiw LayoutTests/http/tests/serviceworker/chromium/*?
5 years, 5 months ago (2015-07-02 10:19:44 UTC) #4
falken
https://codereview.chromium.org/1226473002/diff/40001/LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-generated-mixed-response-worker.js File LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-generated-mixed-response-worker.js (right): https://codereview.chromium.org/1226473002/diff/40001/LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-generated-mixed-response-worker.js#newcode20 LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-generated-mixed-response-worker.js:20: }); indent two spaces https://codereview.chromium.org/1226473002/diff/40001/LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-proxied-mixed-response-worker.js File LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-proxied-mixed-response-worker.js (right): https://codereview.chromium.org/1226473002/diff/40001/LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-proxied-mixed-response-worker.js#newcode11 ...
5 years, 5 months ago (2015-07-03 04:10:37 UTC) #5
horo
https://codereview.chromium.org/1226473002/diff/40001/LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-generated-mixed-response-worker.js File LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-generated-mixed-response-worker.js (right): https://codereview.chromium.org/1226473002/diff/40001/LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-generated-mixed-response-worker.js#newcode20 LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-generated-mixed-response-worker.js:20: }); On 2015/07/03 04:10:36, falken wrote: > indent two ...
5 years, 5 months ago (2015-07-06 11:45:41 UTC) #10
falken
serviceworker test lgtm https://codereview.chromium.org/1226473002/diff/140001/LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-mixed-response-worker.js File LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-mixed-response-worker.js (right): https://codereview.chromium.org/1226473002/diff/140001/LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-mixed-response-worker.js#newcode21 LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-mixed-response-worker.js:21: function geneate_partial_byte_response(position) { nit: generate https://codereview.chromium.org/1226473002/diff/140001/LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-mixed-response-worker.js#newcode28 ...
5 years, 5 months ago (2015-07-07 03:23:11 UTC) #11
horo
Thank you! https://codereview.chromium.org/1226473002/diff/140001/LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-mixed-response-worker.js File LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-mixed-response-worker.js (right): https://codereview.chromium.org/1226473002/diff/140001/LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-mixed-response-worker.js#newcode21 LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-mixed-response-worker.js:21: function geneate_partial_byte_response(position) { On 2015/07/07 03:23:10, falken ...
5 years, 5 months ago (2015-07-07 10:08:11 UTC) #12
horo
hubbe@ Could you please review LayoutTests/http/tests/media/*?
5 years, 5 months ago (2015-07-14 05:35:41 UTC) #13
hubbe
On 2015/07/14 05:35:41, horo wrote: > hubbe@ > Could you please review LayoutTests/http/tests/media/*? I'm afraid ...
5 years, 5 months ago (2015-07-14 17:48:18 UTC) #14
horo
On 2015/07/14 17:48:18, hubbe wrote: > On 2015/07/14 05:35:41, horo wrote: > > hubbe@ > ...
5 years, 5 months ago (2015-07-15 01:52:42 UTC) #16
DaleCurtis
lgtm https://codereview.chromium.org/1226473002/diff/180001/LayoutTests/http/tests/media/mixed-range-response.html File LayoutTests/http/tests/media/mixed-range-response.html (right): https://codereview.chromium.org/1226473002/diff/180001/LayoutTests/http/tests/media/mixed-range-response.html#newcode13 LayoutTests/http/tests/media/mixed-range-response.html:13: // 5. The element sends the thired request ...
5 years, 5 months ago (2015-07-15 22:28:08 UTC) #17
horo
Thank you! https://codereview.chromium.org/1226473002/diff/180001/LayoutTests/http/tests/media/mixed-range-response.html File LayoutTests/http/tests/media/mixed-range-response.html (right): https://codereview.chromium.org/1226473002/diff/180001/LayoutTests/http/tests/media/mixed-range-response.html#newcode13 LayoutTests/http/tests/media/mixed-range-response.html:13: // 5. The element sends the thired ...
5 years, 5 months ago (2015-07-16 02:23:20 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226473002/200001
5 years, 5 months ago (2015-07-16 03:08:42 UTC) #21
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 04:09:40 UTC) #22
Message was sent while issue was closed. 
Committed patchset #5 (id:200001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199001

Powered by Google App Engine
This is Rietveld 408576698