LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-mixed-response.php - Issue 1226473002: Add LayoutTests for mixed range response handling.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-mixed-response.php

Issue 1226473002: Add LayoutTests for mixed range response handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated falken's comment and refactored Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/chromium/resources/blank.html ('k') | LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-mixed-response-worker.js » ('j') | LayoutTests/http/tests/serviceworker/chromium/resources/service-worker-mixed-response-worker.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?php

	2 $position = $_GET["position"];

	3 header('HTTP/1.0 206 Partial Content');

	4 header('Content-Type: audio/ogg');

	5 header('Content-Range: bytes ' . $position . '-' . $position . '/12983');
	falken 2015/07/07 03:23:10 does it make sense to comment what 12983 is from does it make sense to comment what 12983 is from horo 2015/07/07 10:08:11 Done. Show quoted text On 2015/07/07 03:23:10, falken wrote: > does it make sense to comment what 12983 is from Done.
	6 header('Access-Control-Allow-Origin: *');

	7 echo substr('Ogg', $position, 1);

	8 ?>

OLD	NEW