Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1226403008: Merge to M44: Abort on OOM by default in FX_Alloc(). (Closed)

Created:
5 years, 5 months ago by Lei Zhang
Modified:
5 years, 5 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@2403
Target Ref:
refs/heads/chromium/2403
Visibility:
Public.

Description

Merge to M44: Abort on OOM by default in FX_Alloc(). Add a FX_TryAlloc() for those few cases where we might need to continue in face of OOM. Remove FX_AllocNL() (the context of its use would suggest that NL means "No Limit"). This is used for some big allocations, so replace it with TryAlloc(). Large allocations may be worth trying to continue from, since there are few and they have a large chance of failing. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1128043009 (cherry picked from commit 9f6f34892fdfff87c49a9df4c1e34790c0fa1272) BUG=446032 Committed: https://pdfium.googlesource.com/pdfium/+/ce95f50e0ed551f6280f163a05b58031a3d011a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -24 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M core/include/fxcrt/fx_memory.h View 2 chunks +45 lines, -8 lines 0 comments Download
M core/include/fxcrt/fx_system.h View 2 chunks +13 lines, -3 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_memmgr.cpp View 2 chunks +9 lines, -6 lines 0 comments Download
A core/src/fxcrt/fx_basic_memmgr_unittest.cpp View 1 chunk +47 lines, -0 lines 0 comments Download
M core/src/fxge/dib/fx_dib_convert.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_engine.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxge/dib/fx_dib_main.cpp View 1 chunk +1 line, -1 line 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Lei Zhang
5 years, 5 months ago (2015-07-13 19:07:04 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ce95f50e0ed551f6280f163a05b58031a3d011a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698