Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: sky/sdk/lib/widgets/scrollable.dart

Issue 1226373003: demo_launcher/lib/main.dart does not have bottom-overscroll (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/sdk/lib/widgets/scrollable.dart
diff --git a/sky/sdk/lib/widgets/scrollable.dart b/sky/sdk/lib/widgets/scrollable.dart
index 08d2881566724245109cdd2396304ca56232f0c1..6a8beb29c53e4c388934680b797c062656c490c8 100644
--- a/sky/sdk/lib/widgets/scrollable.dart
+++ b/sky/sdk/lib/widgets/scrollable.dart
@@ -27,9 +27,9 @@ enum ScrollDirection { vertical, horizontal }
abstract class Scrollable extends StatefulComponent {
Scrollable({
- String key,
- this.backgroundColor,
- this.direction: ScrollDirection.vertical
+ String key,
+ this.backgroundColor,
+ this.direction: ScrollDirection.vertical
}) : super(key: key);
Color backgroundColor;
@@ -122,6 +122,10 @@ abstract class Scrollable extends StatefulComponent {
super.didUnmount();
}
+ void settleScrollOffset() {
+ _startSimulation(_createParticle());
+ }
+
void _stopSimulation() {
if (_simulation == null)
return;
@@ -147,7 +151,7 @@ abstract class Scrollable extends StatefulComponent {
void _handlePointerUpOrCancel(_) {
if (_simulation == null)
- _startSimulation(_createParticle());
+ settleScrollOffset();
}
void _handleScrollUpdate(sky.GestureEvent event) {
@@ -162,7 +166,7 @@ abstract class Scrollable extends StatefulComponent {
}
void _handleFlingCancel(sky.GestureEvent event) {
- _startSimulation(_createParticle());
+ settleScrollOffset();
}
void _handleWheel(sky.WheelEvent event) {

Powered by Google App Engine
This is Rietveld 408576698