Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1226373003: demo_launcher/lib/main.dart does not have bottom-overscroll (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel, eseidel1, Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

demo_launcher/lib/main.dart does not have bottom-overscroll Rather than trying to clamp the scroll offset during scrolling, we detect when we might have exceeded our maxScrollOffset and settle the scroll offset back in bounds. Fixes #287 R=eseidel@chromium.org, eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/286f85649eb39cd9de1858ff94d3cd1ab64b185d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -21 lines) Patch
M sky/sdk/lib/animation/scroll_behavior.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M sky/sdk/lib/widgets/fixed_height_scrollable.dart View 3 chunks +12 lines, -9 lines 1 comment Download
M sky/sdk/lib/widgets/scrollable.dart View 4 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
abarth-chromium
5 years, 5 months ago (2015-07-09 20:35:53 UTC) #1
Hixie
lgtm
5 years, 5 months ago (2015-07-09 20:39:38 UTC) #3
eseidel
lgtm https://codereview.chromium.org/1226373003/diff/1/sky/sdk/lib/widgets/fixed_height_scrollable.dart File sky/sdk/lib/widgets/fixed_height_scrollable.dart (right): https://codereview.chromium.org/1226373003/diff/1/sky/sdk/lib/widgets/fixed_height_scrollable.dart#newcode43 sky/sdk/lib/widgets/fixed_height_scrollable.dart:43: _updateScrollOffset(); Unneeded.
5 years, 5 months ago (2015-07-09 20:40:08 UTC) #5
abarth-chromium
5 years, 5 months ago (2015-07-09 20:43:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
286f85649eb39cd9de1858ff94d3cd1ab64b185d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698