extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h ('k') | extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc

diff --git a/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc

index a4a1dca880b7083bba5b4908454d53f8ea169e8d..24fad16ca2bc537e0d4886a63a0671b9b935eaca 100644

--- a/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc

+++ b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc

@@ -14,8 +14,8 @@

using content::SocketPermissionRequest;

using extensions::ResumableTCPServerSocket;

-using extensions::core_api::sockets_tcp_server::SocketInfo;

-using extensions::core_api::sockets_tcp_server::SocketProperties;

+using extensions::api::sockets_tcp_server::SocketInfo;

+using extensions::api::sockets_tcp_server::SocketProperties;

namespace {

@@ -59,7 +59,7 @@ void SetSocketProperties(ResumableTCPServerSocket* socket,

} // namespace

namespace extensions {

-namespace core_api {

+namespace api {

TCPServerSocketAsyncApiFunction::~TCPServerSocketAsyncApiFunction() {}

@@ -126,7 +126,7 @@ SocketsTcpServerSetPausedFunction::SocketsTcpServerSetPausedFunction()

SocketsTcpServerSetPausedFunction::~SocketsTcpServerSetPausedFunction() {}

bool SocketsTcpServerSetPausedFunction::Prepare() {

- params_ = core_api::sockets_tcp_server::SetPaused::Params::Create(*args_);

+ params_ = api::sockets_tcp_server::SetPaused::Params::Create(*args_);

EXTENSION_FUNCTION_VALIDATE(params_.get());

socket_event_dispatcher_ =

@@ -163,7 +163,7 @@ SocketsTcpServerListenFunction::SocketsTcpServerListenFunction()

SocketsTcpServerListenFunction::~SocketsTcpServerListenFunction() {}

bool SocketsTcpServerListenFunction::Prepare() {

- params_ = core_api::sockets_tcp_server::Listen::Params::Create(*args_);

+ params_ = api::sockets_tcp_server::Listen::Params::Create(*args_);

EXTENSION_FUNCTION_VALIDATE(params_.get());

socket_event_dispatcher_ =

@@ -297,5 +297,5 @@ void SocketsTcpServerGetSocketsFunction::Work() {

results_ = sockets_tcp_server::GetSockets::Results::Create(socket_infos);

}

-} // namespace core_api

+} // namespace api

} // namespace extensions