chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/declarative_apitest.cc ('k') | chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc b/chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc

index 48652b8cf934fca4c5351e650eaba4f2130d8694..0f0d942c79915ba977a671c2ccd0fef8c7af8404 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc

@@ -20,8 +20,8 @@ const char kExtensionId[] = "foo";

void InsertRule(scoped_refptr<extensions::RulesRegistry> registry,

const std::string& id) {

- std::vector<linked_ptr<extensions::core_api::events::Rule> > add_rules;

- add_rules.push_back(make_linked_ptr(new extensions::core_api::events::Rule));

+ std::vector<linked_ptr<extensions::api::events::Rule>> add_rules;

+ add_rules.push_back(make_linked_ptr(new extensions::api::events::Rule));

add_rules[0]->id.reset(new std::string(id));

std::string error = registry->AddRules(kExtensionId, add_rules);

EXPECT_TRUE(error.empty());

@@ -29,7 +29,7 @@ void InsertRule(scoped_refptr<extensions::RulesRegistry> registry,

void VerifyNumberOfRules(scoped_refptr<extensions::RulesRegistry> registry,

size_t expected_number_of_rules) {

- std::vector<linked_ptr<extensions::core_api::events::Rule> > get_rules;

+ std::vector<linked_ptr<extensions::api::events::Rule>> get_rules;

registry->GetAllRules(kExtensionId, &get_rules);

EXPECT_EQ(expected_number_of_rules, get_rules.size());

}