extensions/browser/api/networking_config/networking_config_service.cc - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_config/networking_config_service.cc

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/chrome_extensions_client.cc ('K') | « extensions/browser/api/networking_config/networking_config_api.cc ('k') | extensions/browser/api/networking_config/networking_config_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_config/networking_config_service.cc

diff --git a/extensions/browser/api/networking_config/networking_config_service.cc b/extensions/browser/api/networking_config/networking_config_service.cc

index 55c90b43889e6a32432f328a7de29a9443272e42..78554033fc7f645958da608bd5513d578c77d4f1 100644

--- a/extensions/browser/api/networking_config/networking_config_service.cc

+++ b/extensions/browser/api/networking_config/networking_config_service.cc

@@ -183,9 +183,8 @@ scoped_ptr<Event> NetworkingConfigService::CreatePortalDetectedEventAndDispatch(

return nullptr;

// Populate the NetworkInfo object.

- extensions::core_api::networking_config::NetworkInfo network_info;

- network_info.type =

- extensions::core_api::networking_config::NETWORK_TYPE_WIFI;

+ extensions::api::networking_config::NetworkInfo network_info;

+ network_info.type = extensions::api::networking_config::NETWORK_TYPE_WIFI;

const std::vector<uint8_t>& raw_ssid = network->raw_ssid();

std::string hex_ssid =

base::HexEncode(vector_as_array(&raw_ssid), raw_ssid.size());

@@ -195,12 +194,12 @@ scoped_ptr<Event> NetworkingConfigService::CreatePortalDetectedEventAndDispatch(

if (bssid)

network_info.bssid.reset(new std::string(*bssid));

scoped_ptr<base::ListValue> results =

- extensions::core_api::networking_config::OnCaptivePortalDetected::Create(

+ extensions::api::networking_config::OnCaptivePortalDetected::Create(

network_info);

- scoped_ptr<Event> event(new Event(events::UNKNOWN,

- extensions::core_api::networking_config::

- OnCaptivePortalDetected::kEventName,

- results.Pass()));

+ scoped_ptr<Event> event(new Event(

+ events::UNKNOWN,

+ extensions::api::networking_config::OnCaptivePortalDetected::kEventName,

+ results.Pass()));

return event.Pass();

}