chrome/common/extensions/chrome_extensions_client.cc - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/chrome_extensions_client.cc

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/chrome_extensions_client.cc

diff --git a/chrome/common/extensions/chrome_extensions_client.cc b/chrome/common/extensions/chrome_extensions_client.cc

index 686db97323b8a551154e78fc1c65b8d6a616e189..7cbbc453e30b111877b0a73a4f2555d9a2f4484d 100644

--- a/chrome/common/extensions/chrome_extensions_client.cc

+++ b/chrome/common/extensions/chrome_extensions_client.cc

@@ -289,7 +289,7 @@ bool ChromeExtensionsClient::IsAPISchemaGenerated(

const std::string& name) const {

// Test from most common to least common.

return api::GeneratedSchemas::IsGenerated(name) ||

- core_api::GeneratedSchemas::IsGenerated(name);

+ api::ChromeGeneratedSchemas::IsGenerated(name);

not at google - send to devlin 2015/07/16 22:08:32 This is the only meaningful non-Python/gyp/gypi/gn

}

base::StringPiece ChromeExtensionsClient::GetAPISchema(

@@ -298,7 +298,7 @@ base::StringPiece ChromeExtensionsClient::GetAPISchema(

if (api::GeneratedSchemas::IsGenerated(name))

return api::GeneratedSchemas::Get(name);

- return core_api::GeneratedSchemas::Get(name);

+ return api::ChromeGeneratedSchemas::Get(name);

}

void ChromeExtensionsClient::RegisterAPISchemaResources(

« no previous file with comments | « chrome/common/extensions/api/schemas.gypi ('k') | extensions/browser/api/alarms/alarm_manager.h » ('j') | no next file with comments »