Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 1226303003: Start the migration of passwords from the Keychain. (Closed)

Created:
5 years, 5 months ago by vasilii
Modified:
5 years, 5 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, asvitkine+watch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 : Original CL #

Patch Set 2 : fix the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -93 lines) Patch
M chrome/browser/password_manager/password_store_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_mac.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac_unittest.cc View 5 chunks +16 lines, -46 lines 0 comments Download
M chrome/browser/password_manager/password_store_proxy_mac.h View 1 5 chunks +30 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_proxy_mac.cc View 3 chunks +84 lines, -12 lines 0 comments Download
M chrome/browser/password_manager/password_store_proxy_mac_unittest.cc View 1 11 chunks +156 lines, -14 lines 0 comments Download
M chrome/browser/password_manager/simple_password_store_mac.h View 2 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/password_manager/simple_password_store_mac.cc View 1 chunk +14 lines, -7 lines 0 comments Download
M chrome/browser/password_manager/simple_password_store_mac_unittest.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M components/password_manager.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A components/password_manager/core/browser/keychain_migration_status_mac.h View 1 chunk +31 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_manager.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store_default.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/password_manager/core/common/password_manager_pref_names.h View 1 chunk +6 lines, -0 lines 0 comments Download
M components/password_manager/core/common/password_manager_pref_names.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vasilii
Hi Vaclav, please review the difference between Patch set #1 and #2.
5 years, 5 months ago (2015-07-09 08:57:44 UTC) #2
vabr (Chromium)
LGTM, thanks for the quick fix, Vasilii! Vaclav
5 years, 5 months ago (2015-07-09 09:06:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226303003/20001
5 years, 5 months ago (2015-07-09 10:31:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-09 10:35:47 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 10:37:09 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c711b5767ccea7095621defa2fb77580a132cca
Cr-Commit-Position: refs/heads/master@{#338010}

Powered by Google App Engine
This is Rietveld 408576698