chrome/browser/password_manager/password_store_factory.cc - Issue 1226303003: Start the migration of passwords from the Keychain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_factory.cc

Issue 1226303003: Start the migration of passwords from the Keychain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix the test Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/password_manager/password_store_factory.cc

diff --git a/chrome/browser/password_manager/password_store_factory.cc b/chrome/browser/password_manager/password_store_factory.cc

index b43d985f927dbb72e4ff8d38eba9981d56fe21a9..0adf18df0d6140072da696dc8138c300a07b6409 100644

--- a/chrome/browser/password_manager/password_store_factory.cc

+++ b/chrome/browser/password_manager/password_store_factory.cc

@@ -271,7 +271,7 @@ KeyedService* PasswordStoreFactory::BuildServiceInstanceFor(

? new crypto::MockAppleKeychain()

: new crypto::AppleKeychain());

ps = new PasswordStoreProxyMac(main_thread_runner, keychain.Pass(),

- login_db.Pass());

+ login_db.Pass(), profile->GetPrefs());

#elif defined(OS_CHROMEOS) || defined(OS_ANDROID)

// For now, we use PasswordStoreDefault. We might want to make a native

// backend for PasswordStoreX (see below) in the future though.

« no previous file with comments | « no previous file | chrome/browser/password_manager/password_store_mac.cc » ('j') | no next file with comments »