Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 1226243004: win: Remove a few instances of the "goto error" pattern. (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Remove a few instances of the "goto error" pattern. This makes the code simpler, and also fixes a bunch of warnings that look like: goto done; ^ ..\..\remoting\host\win\rdp_client_window.cc(331,14) : note(clang): jump bypasses variable initialization const LONG kDesiredFlags = WTS_PERF_ENABLE_ENHANCED_GRAPHICS | ^ No intended behavior change. BUG=505296 Committed: https://crrev.com/e03b42a70818ae8b0edb3d40fcdb6df9cdc20fd5 Cr-Commit-Position: refs/heads/master@{#338720}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -88 lines) Patch
M printing/printing_context_win_unittest.cc View 1 2 3 4 5 5 chunks +40 lines, -54 lines 0 comments Download
M remoting/host/win/rdp_client_window.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 1 comment Download
M remoting/host/win/rdp_client_window.cc View 6 chunks +31 lines, -34 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Nico
vitalybuka: printing/ wez: remoting/
5 years, 5 months ago (2015-07-14 13:20:34 UTC) #2
Sergey Ulanov
remoting LGTM. Thank you for the cleanup! https://codereview.chromium.org/1226243004/diff/110001/remoting/host/win/rdp_client_window.h File remoting/host/win/rdp_client_window.h (right): https://codereview.chromium.org/1226243004/diff/110001/remoting/host/win/rdp_client_window.h#newcode129 remoting/host/win/rdp_client_window.h:129: int LogOnCreateError(HRESULT ...
5 years, 5 months ago (2015-07-14 16:09:50 UTC) #4
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 5 months ago (2015-07-14 18:33:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226243004/110001
5 years, 5 months ago (2015-07-14 18:35:19 UTC) #7
commit-bot: I haz the power
Committed patchset #7 (id:110001)
5 years, 5 months ago (2015-07-14 18:44:22 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 18:45:15 UTC) #9
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/e03b42a70818ae8b0edb3d40fcdb6df9cdc20fd5
Cr-Commit-Position: refs/heads/master@{#338720}

Powered by Google App Engine
This is Rietveld 408576698