Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Side by Side Diff: remoting/host/win/rdp_client_window.h

Issue 1226243004: win: Remove a few instances of the "goto error" pattern. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « printing/printing_context_win_unittest.cc ('k') | remoting/host/win/rdp_client_window.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef REMOTING_HOST_WIN_RDP_HOST_WINDOW_H_ 5 #ifndef REMOTING_HOST_WIN_RDP_HOST_WINDOW_H_
6 #define REMOTING_HOST_WIN_RDP_HOST_WINDOW_H_ 6 #define REMOTING_HOST_WIN_RDP_HOST_WINDOW_H_
7 7
8 #include <atlbase.h> 8 #include <atlbase.h>
9 #include <atlcom.h> 9 #include <atlcom.h>
10 #include <atlcrack.h> 10 #include <atlcrack.h>
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 END_SINK_MAP() 119 END_SINK_MAP()
120 120
121 // mstsc::IMsTscAxEvents notifications. 121 // mstsc::IMsTscAxEvents notifications.
122 STDMETHOD(OnAuthenticationWarningDisplayed)(); 122 STDMETHOD(OnAuthenticationWarningDisplayed)();
123 STDMETHOD(OnAuthenticationWarningDismissed)(); 123 STDMETHOD(OnAuthenticationWarningDismissed)();
124 STDMETHOD(OnConnected)(); 124 STDMETHOD(OnConnected)();
125 STDMETHOD(OnDisconnected)(long reason); 125 STDMETHOD(OnDisconnected)(long reason);
126 STDMETHOD(OnFatalError)(long error_code); 126 STDMETHOD(OnFatalError)(long error_code);
127 STDMETHOD(OnConfirmClose)(VARIANT_BOOL* allow_close); 127 STDMETHOD(OnConfirmClose)(VARIANT_BOOL* allow_close);
128 128
129 int LogOnCreateError(HRESULT error);
Sergey Ulanov 2015/07/14 16:09:50 Please add a comment here, e.g.: Helper used to ha
130
129 // Wrappers for the event handler's methods that make sure that 131 // Wrappers for the event handler's methods that make sure that
130 // OnDisconnected() is the last notification delivered and is delevered 132 // OnDisconnected() is the last notification delivered and is delevered
131 // only once. 133 // only once.
132 void NotifyConnected(); 134 void NotifyConnected();
133 void NotifyDisconnected(); 135 void NotifyDisconnected();
134 136
135 // Invoked to report connect/disconnect events. 137 // Invoked to report connect/disconnect events.
136 EventHandler* event_handler_; 138 EventHandler* event_handler_;
137 139
138 // Contains the requested dimensions of the screen. 140 // Contains the requested dimensions of the screen.
(...skipping 10 matching lines...) Expand all
149 base::win::ScopedComPtr<mstsc::IMsRdpClientAdvancedSettings> client_settings_; 151 base::win::ScopedComPtr<mstsc::IMsRdpClientAdvancedSettings> client_settings_;
150 152
151 // Used to cancel modal dialog boxes shown by the RDP control. 153 // Used to cancel modal dialog boxes shown by the RDP control.
152 class WindowHook; 154 class WindowHook;
153 scoped_refptr<WindowHook> window_activate_hook_; 155 scoped_refptr<WindowHook> window_activate_hook_;
154 }; 156 };
155 157
156 } // namespace remoting 158 } // namespace remoting
157 159
158 #endif // REMOTING_HOST_WIN_RDP_HOST_WINDOW_H_ 160 #endif // REMOTING_HOST_WIN_RDP_HOST_WINDOW_H_
OLDNEW
« no previous file with comments | « printing/printing_context_win_unittest.cc ('k') | remoting/host/win/rdp_client_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698