Chromium Code Reviews Chromium Code Reviews
Issue
1226213002:
Sync: Support nodes with implicit permanent folders: Node Browser and out-of-order loading from DB (Closed)
DescriptionSync: Support nodes with implicit permanent folders:
Node Browser and out-of-order loading from DB
The fix contains two parts:
1) Changed Sync Node Browser code to handle nodes with unset
PARENT_ID. The parent ID would be unset only for nodes with
flat hierarchy where all the nodes are under the same type
root folder. In that case the parent-child relationship is
determined based on the node's model type.
EntryKernel::ToValue already generated serverModelType field,
although it would be unset for nodes that never synced to
the server. To make it more reliable I changed the field to
modelType and added the code to set it based on combination
of both server and client model type. Most of the change
deals with renaming serverModelType to modelType.
2) When testing the issue #1 with an older account I noticed
issues with ParentChildIndex not associating a few
nodes (with implicit Parent ID) correctly with their
corresponding permanent folders.
The issue turned out to be caused by an arbitrary out-of-order
loading of nodes from the database. When a node with unset Parent ID
was inserted before its permanent folder, ParentChildIndex
would place it in the OrderedChildSet associated with empty ("")
ParentID and this node would essentially be invisible
for the rest of the code querying the index.
To handle this out-of-order insertion correctly, I changed
data organization in ParentChildIndex. There now two data
structures:
a) Parent ID to OrderedChildSet map is still used to organize
collections of children for types with explicit
Parent ID like bookmarks.
b) There is also an array of OrderedChildSet indexed by
model type which contains flat collections of entries for
non-hierarchical types.
c) The latter type of collections are also shared with the
Parent ID to OrderedChildSet map so that querying by
Parent ID still works non-hierarchical types.
The sharing occurs when the index sees an entry that it
recognizes as a type root folder.
BUG=438313
TBR=nkostylev@chromium.org
Committed: https://crrev.com/c2b13973453530ab01e92fee880e14b34c0c420b
Cr-Commit-Position: refs/heads/master@{#338364}
Patch Set 1 #Patch Set 2 : Fixed tests #Patch Set 3 : Fixed memory leak #
Total comments: 17
Patch Set 4 : Addressed CR feedback #
Total comments: 8
Patch Set 5 : Added <vector> include #Patch Set 6 : Addressed second round of CR #
Total comments: 4
Patch Set 7 : Changed comments #Messages
Total messages: 15 (3 generated)
|
