Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: sync/syncable/model_type.cc

Issue 1226213002: Sync: Support nodes with implicit permanent folders: Node Browser and out-of-order loading from DB (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed memory leak Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/internal_api/public/base/model_type.h" 5 #include "sync/internal_api/public/base/model_type.h"
6 6
7 #include "base/strings/string_split.h" 7 #include "base/strings/string_split.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "sync/protocol/app_notification_specifics.pb.h" 9 #include "sync/protocol/app_notification_specifics.pb.h"
10 #include "sync/protocol/app_setting_specifics.pb.h" 10 #include "sync/protocol/app_setting_specifics.pb.h"
(...skipping 1198 matching lines...) Expand 10 before | Expand all | Expand 10 after
1209 1209
1210 bool IsTypeWithServerGeneratedRoot(ModelType model_type) { 1210 bool IsTypeWithServerGeneratedRoot(ModelType model_type) {
1211 return model_type == BOOKMARKS || model_type == NIGORI; 1211 return model_type == BOOKMARKS || model_type == NIGORI;
1212 } 1212 }
1213 1213
1214 bool IsTypeWithClientGeneratedRoot(ModelType model_type) { 1214 bool IsTypeWithClientGeneratedRoot(ModelType model_type) {
1215 return IsRealDataType(model_type) && 1215 return IsRealDataType(model_type) &&
1216 !IsTypeWithServerGeneratedRoot(model_type); 1216 !IsTypeWithServerGeneratedRoot(model_type);
1217 } 1217 }
1218 1218
1219 bool TypeSupportsHierarchy(ModelType model_type) {
1220 return model_type == BOOKMARKS;
Nicolas Zea 2015/07/09 20:36:34 should this include TOP_LEVEL_FOLDER?
stanisc 2015/07/09 21:45:16 Perhaps. Is TOP_LEVEL_FOLDER type actually used ot
stanisc 2015/07/09 23:59:27 Added TODO. Adding TOP_LEVEL_FOLDER might affect t
1221 }
1222
1223 bool TypeSupportsOrdering(ModelType model_type) {
1224 return model_type == BOOKMARKS;
1225 }
1226
1219 } // namespace syncer 1227 } // namespace syncer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698