Sync: Support nodes with implicit permanent folders: Node Browser and out-of-order loading from DB

sync/syncable/model_type.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/internal_api/public/base/model_type.h"
 
 #include "base/strings/string_split.h"
 #include "base/values.h"
 #include "sync/protocol/app_notification_specifics.pb.h"
 #include "sync/protocol/app_setting_specifics.pb.h"
@@ skipping 1198 matching lines @@
 
 bool IsTypeWithServerGeneratedRoot(ModelType model_type) {
   return model_type == BOOKMARKS || model_type == NIGORI;
 }
 
 bool IsTypeWithClientGeneratedRoot(ModelType model_type) {
   return IsRealDataType(model_type) &&
          !IsTypeWithServerGeneratedRoot(model_type);
 }
 
+bool TypeSupportsHierarchy(ModelType model_type) {
+  return model_type == BOOKMARKS;

[Nicolas Zea, 2015/07/09 20:36:34]

should this include TOP_LEVEL_FOLDER?

[stanisc, 2015/07/09 21:45:16]

Perhaps. Is TOP_LEVEL_FOLDER type actually used other than in some old tests?

[stanisc, 2015/07/09 23:59:27]

Added TODO. Adding TOP_LEVEL_FOLDER might affect the code that calls
EntryKernel::ShouldMaintainHierarchy. We should review how TOP_LEVEL_FOLDER is
used in the code first.

+}
+
+bool TypeSupportsOrdering(ModelType model_type) {
+  return model_type == BOOKMARKS;
+}
+
 }  // namespace syncer