samples/swarm/swarm_ui_lib/observable/observable.dart - Issue 12262037: Make List.skip, List.take and List.reversed return Iterables, not Lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/swarm/swarm_ui_lib/observable/observable.dart

Issue 12262037: Make List.skip, List.take and List.reversed return Iterables, not Lists. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments, small fixes. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: samples/swarm/swarm_ui_lib/observable/observable.dart

diff --git a/samples/swarm/swarm_ui_lib/observable/observable.dart b/samples/swarm/swarm_ui_lib/observable/observable.dart

index 06931db0fda5df7351313c646ce107449fb25aab..2294f070586826295ae82523557a82c1e118ce2f 100644

--- a/samples/swarm/swarm_ui_lib/observable/observable.dart

+++ b/samples/swarm/swarm_ui_lib/observable/observable.dart

@@ -162,7 +162,7 @@ class ObservableList<T>

recordGlobalChange();

}

- List<T> get reversed => _internal.reversed;

+ Iterable<T> get reversed => _internal.reversed;

void sort([int compare(var a, var b)]) {

if (compare == null) compare = Comparable.compare;

« no previous file with comments | « runtime/lib/growable_array.dart ('k') | sdk/lib/_collection_dev/iterable.dart » ('j') | no next file with comments »