runtime/lib/growable_array.dart - Issue 12262037: Make List.skip, List.take and List.reversed return Iterables, not Lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/growable_array.dart

Issue 12262037: Make List.skip, List.take and List.reversed return Iterables, not Lists. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments, small fixes. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/growable_array.dart

diff --git a/runtime/lib/growable_array.dart b/runtime/lib/growable_array.dart

index 5bd89879df7272155a957db3de7e50861f5670bf..d030e64acc1342ec1559fe33186c6a82f510d43c 100644

--- a/runtime/lib/growable_array.dart

+++ b/runtime/lib/growable_array.dart

@@ -310,7 +310,7 @@ class _GrowableObjectArray<T> implements List<T> {

this.length = 0;

}

- List<T> get reversed => new ReversedListView<T>(this, 0, null);

+ Iterable<T> get reversed => new ReversedListIterable<T>(this);

void sort([int compare(T a, T b)]) {

IterableMixinWorkaround.sortList(this, compare);

« no previous file with comments | « runtime/lib/array.dart ('k') | samples/swarm/swarm_ui_lib/observable/observable.dart » ('j') | no next file with comments »