Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 12262019: Replace static/native-desktop-only BrowserList::const_reverse_iterator by desktop specific ... (Closed)

Created:
7 years, 10 months ago by gab
Modified:
7 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Replace static/native-desktop-only BrowserList::const_reverse_iterator by desktop specific reverse iterators as appropriate. BUG=129187 Originally committed in: https://src.chromium.org/viewvc/chrome?view=rev&revision=182463 Reverted in: https://src.chromium.org/viewvc/chrome?view=rev&revision=182476 (breaks ChromeLauncherControllerPerAppTest.BrowserMenuGeneration in unit_tests on win7_aura) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182484

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : chrome_launcher_controller_per_app_unittest should be creating browsers on the ash desktop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_unittest.cc View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_list.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer.cc View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
gab
Scott, please take a look. Thanks! Gab
7 years, 10 months ago (2013-02-13 21:53:28 UTC) #1
sky
LGTM
7 years, 10 months ago (2013-02-13 22:29:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/12262019/1
7 years, 10 months ago (2013-02-13 22:52:19 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) aura_unittests, browser_tests, compositor_unittests, content_browsertests, content_unittests, interactive_ui_tests, ...
7 years, 10 months ago (2013-02-13 23:26:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/12262019/1
7 years, 10 months ago (2013-02-14 00:12:14 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) aura_unittests, browser_tests, compositor_unittests, content_browsertests, content_unittests, interactive_ui_tests, ...
7 years, 10 months ago (2013-02-14 00:46:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/12262019/1
7 years, 10 months ago (2013-02-14 02:19:06 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-14 02:58:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/12262019/1
7 years, 10 months ago (2013-02-14 05:28:18 UTC) #9
gab
7 years, 10 months ago (2013-02-14 16:58:23 UTC) #10
Scott, fyi, small test tweak to make this not break the waterfall. Recommitting
now.

Powered by Google App Engine
This is Rietveld 408576698