chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc - Issue 12262019: Replace static/native-desktop-only BrowserList::const_reverse_iterator by desktop specific ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc

Issue 12262019: Replace static/native-desktop-only BrowserList::const_reverse_iterator by desktop specific ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: chrome_launcher_controller_per_app_unittest should be creating browsers on the ash desktop Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc

index 89ab329b1fe188261461ac7de7bdef3e69430cec..0970835c3313d2ae54b3ea018e9d2fa2403ebd20 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc

@@ -1371,10 +1371,12 @@ ChromeLauncherControllerPerApp::GetBrowserApplicationList() {

items.push_back(new ChromeLauncherAppMenuItem(

l10n_util::GetStringFUTF16(IDS_LAUNCHER_CHROME_BROWSER_NAME,

l10n_util::GetStringUTF16(IDS_PRODUCT_NAME)), NULL));

+ const chrome::BrowserListImpl* ash_browser_list =

+ chrome::BrowserListImpl::GetInstance(chrome::HOST_DESKTOP_TYPE_ASH);

int index = 1;

- for (BrowserList::const_reverse_iterator it =

- BrowserList::begin_last_active();

- it != BrowserList::end_last_active(); ++it, ++index) {

+ for (chrome::BrowserListImpl::const_reverse_iterator it =

+ ash_browser_list->begin_last_active();

+ it != ash_browser_list->end_last_active(); ++it, ++index) {

Browser* browser = *it;

if (browser->is_type_tabbed())

found_tabbed_browser = true;