[Cleanup] Files.app: Adds missing periods at the end of the descriptions.

[Cleanup] Files.app: Adds missing periods at the end of the descriptions.

Closure linter checks if descriptions end with valid punctuation such as a period. This patch adds periods.

BUG=175657
TEST=none
TBR=mtomasz@chromium.org, haruki@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182217

[commit-bot: I haz the power, 2013-02-13 12:46:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/12262003/3023

[commit-bot: I haz the power, 2013-02-13 12:46:36]

Presubmit check for 12262003-3023 failed and returned exit status 1.

INFO:root:Found 22 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/resources/PRESUBMIT.py

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

See the JavaScript style guide at
http://www.chromium.org/developers/web-development-style-guide#TOC-JavaScript
and if you have any feedback about the JavaScript PRESUBMIT check, contact
tbreisacher@chromium.org or dbeam@chromium.org

** Presubmit Warnings **
Found JavaScript style violations in
chrome/browser/resources/file_manager/js/image_editor/image_encoder.js:
  line 11: E0220: No docs found for member 'ImageEncoder.metadataEncoders'
ImageEncoder.metadataEncoders = {};
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 14: E0220: No docs found for member
'ImageEncoder.registerMetadataEncoder'
ImageEncoder.registerMetadataEncoder = function(constructor, mimeType) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 144: E0220: No docs found for member 'ImageEncoder.stringToArrayBuffer'
ImageEncoder.stringToArrayBuffer = function(string, from, to) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 171: E0220: No docs found for member
'ImageEncoder.MetadataEncoder.prototype.getMetadata'
ImageEncoder.MetadataEncoder.prototype.getMetadata = function() {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Found JavaScript style violations in
chrome/browser/resources/file_manager/js/image_editor/image_view.js:
  line 41: E0221: Member "this.screenImage_" must have @private JsDoc.
  this.screenImage_ = null;
  ^^^^^^^^^^^^^^^^^

Found JavaScript style violations in
chrome/browser/resources/file_manager/js/media/media_controls.js:
  line 755: E0221: Member "this.valueToString_" must have @private JsDoc.
  this.valueToString_ = null;
  ^^^^^^^^^^^^^^^^^^^

Found JavaScript style violations in
chrome/browser/resources/file_manager/js/metadata/exif_parser.js:
  line 31: E0220: No docs found for member 'ExifParser.prototype.parse'
ExifParser.prototype.parse = function(file, metadata, callback, errorCallback) {
^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 35: E0220: No docs found for member 'ExifParser.prototype.requestSlice'
ExifParser.prototype.requestSlice = function(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 49: E0220: No docs found for member 'ExifParser.prototype.parseSlice'
ExifParser.prototype.parseSlice = function(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 115: E0220: No docs found for member 'ExifParser.isSOF_'
ExifParser.isSOF_ = function(mark) {
^^^^^^^^^^^^^^^^^
  line 125: E0220: No docs found for member
'ExifParser.prototype.parseExifSection'
ExifParser.prototype.parseExifSection = function(metadata, buf, br) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 208: E0220: No docs found for member 'ExifParser.setImageSize'
ExifParser.setImageSize = function(metadata, width, height) {
^^^^^^^^^^^^^^^^^^^^^^^
  line 218: E0220: No docs found for member 'ExifParser.prototype.readMark'
ExifParser.prototype.readMark = function(br) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 222: E0220: No docs found for member
'ExifParser.prototype.readMarkLength'
ExifParser.prototype.readMarkLength = function(br) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 227: E0220: No docs found for member 'ExifParser.prototype.readDirectory'
ExifParser.prototype.readDirectory = function(br, tags) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 240: E0220: No docs found for member 'ExifParser.prototype.readTagValue'
ExifParser.prototype.readTagValue = function(br, tag) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 344: E0220: No docs found for member 'ExifParser.SCALEX'
ExifParser.SCALEX = [1, -1, -1, 1, 1, 1, -1, -1];
^^^^^^^^^^^^^^^^^
  line 347: E0220: No docs found for member 'ExifParser.SCALEY'
ExifParser.SCALEY = [1, 1, -1, -1, -1, 1, 1, -1];
^^^^^^^^^^^^^^^^^
  line 350: E0220: No docs found for member 'ExifParser.ROTATE90'
ExifParser.ROTATE90 = [0, 0, 0, 0, 1, 1, 1, 1];
^^^^^^^^^^^^^^^^^^^

Found JavaScript style violations in
chrome/browser/resources/file_manager/js/metadata/function_parallel.js:
  line 9: E0213: Missing type in @param tag
 * @param steps             array of functions to invoke in parallel.
   ^^^^^^
  line 10: E0213: Missing type in @param tag
 * @param callback          callback to invoke on success.
   ^^^^^^
  line 11: E0213: Missing type in @param tag
 * @param failureCallback   callback to invoke on failure.
   ^^^^^^
  line 13: E0210: Missing docs for parameter: "name"
function FunctionParallel(name, steps, logger, callback, failureCallback) {
                                                                        ^^
  line 13: E0210: Missing docs for parameter: "logger"
function FunctionParallel(name, steps, logger, callback, failureCallback) {
                                                                        ^^
  line 34: E0213: Missing type in @param tag
 * @param err error message.
   ^^^^^^
  line 36: E0221: Member "FunctionParallel.prototype.onError_" must have
@private JsDoc.
FunctionParallel.prototype.onError_ = function(err) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 48: E0221: Member "FunctionParallel.prototype.nextStep_" must have
@private JsDoc.
FunctionParallel.prototype.nextStep_ = function() {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 58: E0210: Missing docs for parameter: "var_args"
FunctionParallel.prototype.start = function(var_args) {
                                                    ^^
  line 60: E0120: Binary operator should go on previous line "+"
                    + arguments.length + ' argument(s)');
                    ^
  line 66: E0002: Missing space before "="
  for (var i=0; i < this.steps_.length; i++) {
            ^
  line 66: E0002: Missing space after "="
  for (var i=0; i < this.steps_.length; i++) {
            ^
  line 70: E0002: Missing space before "("
    } catch(e) {
           ^

Found JavaScript style violations in
chrome/browser/resources/file_manager/js/metadata/function_sequence.js:
  line 14: E0210: Missing docs for parameter: "name"
function FunctionSequence(name, steps, logger, callback, failureCallback) {
                                                                        ^^
  line 14: E0212: Parameter mismatch: got "failureCallback", expected "callback"
function FunctionSequence(name, steps, logger, callback, failureCallback) {
                                                                        ^^
  line 53: E0213: Missing type in @param tag
 * @param err error message.
   ^^^^^^
  line 55: E0221: Member "FunctionSequence.prototype.onError_" must have
@private JsDoc.
FunctionSequence.prototype.onError_ = function(err) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 57: E0120: Binary operator should go on previous line "+"
      + ': '
      ^
  line 58: E0120: Binary operator should go on previous line "+"
      + err);
      ^
  line 71: E0221: Member "FunctionSequence.prototype.finish_" must have @private
JsDoc.
FunctionSequence.prototype.finish_ = function() {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 84: E0221: Member "FunctionSequence.prototype.nextStep_" must have
@private JsDoc.
FunctionSequence.prototype.nextStep_ = function(var_args) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 84: E0210: Missing docs for parameter: "var_args"
FunctionSequence.prototype.nextStep_ = function(var_args) {
                                                        ^^
  line 94: E0120: Binary operator should go on previous line "+"
                      + this.steps_[this.currentStepIdx_].name
                      ^
  line 95: E0120: Binary operator should go on previous line "+"
                      + ']');
                      ^
  line 98: E0002: Missing space before "("
    } catch(e) {
           ^
  line 107: E0210: Missing docs for parameter: "var_args"
FunctionSequence.prototype.start = function(var_args) {
                                                    ^^
  line 112: E0131: Single-quoted string preferred over double-quoted string.
  this.logger.log("Starting sequence with " + arguments.length + " arguments");
                  ^
  line 112: E0131: Single-quoted string preferred over double-quoted string.
  this.logger.log("Starting sequence with " + arguments.length + " arguments");
                                                                 ^
  line 121: E0221: Member "FunctionSequence.prototype.apply_" must have @private
JsDoc.
FunctionSequence.prototype.apply_ = function(obj, args) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 121: E0210: Missing docs for parameter: "obj"
FunctionSequence.prototype.apply_ = function(obj, args) {
                                                      ^^
  line 121: E0210: Missing docs for parameter: "args"
FunctionSequence.prototype.apply_ = function(obj, args) {
                                                      ^^

Found JavaScript style violations in
chrome/browser/resources/file_manager/js/metadata/id3_parser.js:
  line 20: E0214: Missing description in @return tag
 * @return {int}
   ^^^^^^^
  line 22: E0221: Member "Id3Parser.readSynchSafe_" must have @private JsDoc.
Id3Parser.readSynchSafe_ = function(reader, length) {
^^^^^^^^^^^^^^^^^^^^^^^^
  line 43: E0214: Missing description in @return tag
 * @return {int}
   ^^^^^^^
  line 45: E0221: Member "Id3Parser.readUInt24_" must have @private JsDoc.
Id3Parser.readUInt24_ = function(reader) {
^^^^^^^^^^^^^^^^^^^^^
  line 57: E0221: Member "Id3Parser.prototype.readString_" must have @private
JsDoc.
Id3Parser.prototype.readString_ = function(reader, encoding, size) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 56: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 88: E0221: Member "Id3Parser.prototype.readTextFrame_" must have @private
JsDoc.
Id3Parser.prototype.readTextFrame_ = function(reader,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  line 104: E0221: Member "Id3Parser…
(message too large)

[Haruki Sato, 2013-02-14 03:47:36]

lgtm

seems like PRESUBMIT has linter checks and found more errors :P

I confirmed that this CL only has modifications in comments and safe to dcommit
(with a TODO if you like).
or you can fix the other errors at the same time if possible.

Thank you for the cleanup!!