Componentize //chrome/browser/offline_pages

components/offline_pages.gypi

Index: components/offline_pages.gypi
diff --git a/components/offline_pages.gypi b/components/offline_pages.gypi
index 668c8062dc5040d89c7f7edb2be31ab71151d7cc..7b2694b6103835291f8f8b2c7657e3f95779a3ae 100644
--- a/components/offline_pages.gypi
+++ b/components/offline_pages.gypi
@@ -15,6 +15,7 @@
         '../base/base.gyp:base',
         '../net/net.gyp:net',
         '../url/url.gyp:url_lib',
+        '../third_party/leveldatabase/leveldatabase.gyp:leveldatabase',
         'keyed_service_core',
       ],
       'sources': [
@@ -25,7 +26,15 @@
         'offline_pages/offline_page_model.h',
         'offline_pages/offline_page_metadata_store.cc',
         'offline_pages/offline_page_metadata_store.h',
+        'offline_pages/offline_page_metadata_store_impl.cc',
+        'offline_pages/offline_page_metadata_store_impl.h',
+        'offline_pages/proto/offline_pages.proto',
       ],
+      'variables': {
+        'proto_in_dir': 'offline_pages/proto',
+        'proto_out_dir': 'components/offline_pages/proto',
+      },

[RaviKasibhatla, 2015/07/13 14:44:19]

For the GN build system, we are following a deps model system i.e. offline_pages
target depends on proto target (defined in offline_pages/proto/BUILD.gn).

However, for gyp model, we are directly including the .proto source files and
the generation scripts. This is different from the existing model
(chrome_browser.gypi) which was also following the deps model.

Is this something intentionally intended?

[blundell, 2015/07/15 09:44:34]

+1 that the target structure should be parallel for consistency.

[Abhishek, 2015/07/15 14:24:22]

Done.
Yeah! I've followed the same deps model system for both the build.

+      'includes': [ '../build/protoc.gypi', ],
     },
   ],
 }