Componentize //chrome/browser/offline_pages

components/offline_pages.gypi

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       # GN: //components/offline_pages:offline_pages
       'target_name': 'offline_pages',
       'type': 'static_library',
       'include_dirs': [
         '..',
       ],
       'dependencies': [
         '../base/base.gyp:base',
         '../net/net.gyp:net',
         '../url/url.gyp:url_lib',
+        '../third_party/leveldatabase/leveldatabase.gyp:leveldatabase',
         'keyed_service_core',
       ],
       'sources': [
         'offline_pages/offline_page_archiver.h',
         'offline_pages/offline_page_item.cc',
         'offline_pages/offline_page_item.h',
         'offline_pages/offline_page_model.cc',
         'offline_pages/offline_page_model.h',
         'offline_pages/offline_page_metadata_store.cc',
         'offline_pages/offline_page_metadata_store.h',
+        'offline_pages/offline_page_metadata_store_impl.cc',
+        'offline_pages/offline_page_metadata_store_impl.h',
+        'offline_pages/proto/offline_pages.proto',
       ],
+      'variables': {
+        'proto_in_dir': 'offline_pages/proto',
+        'proto_out_dir': 'components/offline_pages/proto',
+      },

[RaviKasibhatla, 2015/07/13 14:44:19]

For the GN build system, we are following a deps model system i.e. offline_pages
target depends on proto target (defined in offline_pages/proto/BUILD.gn).

However, for gyp model, we are directly including the .proto source files and
the generation scripts. This is different from the existing model
(chrome_browser.gypi) which was also following the deps model.

Is this something intentionally intended?

[blundell, 2015/07/15 09:44:34]

+1 that the target structure should be parallel for consistency.

[Abhishek, 2015/07/15 14:24:22]

Done.
Yeah! I've followed the same deps model system for both the build.

+      'includes': [ '../build/protoc.gypi', ],
     },
   ],
 }