Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1226163009: Convert usages of mojo::ErrorHandler in //device to callbacks. (Closed)

Created:
5 years, 5 months ago by leonhsl(Using Gerrit)
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert usages of mojo::ErrorHandler in //device to callbacks. BUG=504666 Committed: https://crrev.com/ccab7172be7aa1053248613b5c4576e9b913f5ce Cr-Commit-Position: refs/heads/master@{#338426}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -34 lines) Patch
M device/devices_app/devices_app.h View 1 3 chunks +3 lines, -5 lines 0 comments Download
M device/devices_app/devices_app.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/devices_app/usb/device_manager_impl.h View 2 chunks +1 line, -5 lines 0 comments Download
M device/devices_app/usb/device_manager_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M device/devices_app/usb/device_manager_impl_unittest.cc View 3 chunks +1 line, -20 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
leonhsl(Using Gerrit)
PTAL, Thanks~
5 years, 5 months ago (2015-07-10 13:14:15 UTC) #2
Ken Rockot(use gerrit already)
lgtm, thanks! https://codereview.chromium.org/1226163009/diff/1/device/devices_app/devices_app.h File device/devices_app/devices_app.h (left): https://codereview.chromium.org/1226163009/diff/1/device/devices_app/devices_app.h#oldcode14 device/devices_app/devices_app.h:14: #include "third_party/mojo/src/mojo/public/cpp/bindings/error_handler.h" nit: Please remove this too
5 years, 5 months ago (2015-07-10 15:40:58 UTC) #3
leonhsl(Using Gerrit)
Thanks for review~ https://codereview.chromium.org/1226163009/diff/1/device/devices_app/devices_app.h File device/devices_app/devices_app.h (left): https://codereview.chromium.org/1226163009/diff/1/device/devices_app/devices_app.h#oldcode14 device/devices_app/devices_app.h:14: #include "third_party/mojo/src/mojo/public/cpp/bindings/error_handler.h" On 2015/07/10 15:40:58, Ken ...
5 years, 5 months ago (2015-07-10 16:20:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226163009/20001
5 years, 5 months ago (2015-07-10 16:21:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/77162) (exceeded global retry quota)
5 years, 5 months ago (2015-07-10 17:06:34 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226163009/20001
5 years, 5 months ago (2015-07-11 01:56:35 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-11 02:00:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226163009/20001
5 years, 5 months ago (2015-07-11 02:02:04 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-11 02:05:56 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-11 02:06:56 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ccab7172be7aa1053248613b5c4576e9b913f5ce
Cr-Commit-Position: refs/heads/master@{#338426}

Powered by Google App Engine
This is Rietveld 408576698