device/devices_app/usb/device_manager_impl.cc - Issue 1226163009: Convert usages of mojo::ErrorHandler in //device to callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/devices_app/usb/device_manager_impl.cc

Issue 1226163009: Convert usages of mojo::ErrorHandler in //device to callbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comment. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/devices_app/usb/device_manager_impl.cc

diff --git a/device/devices_app/usb/device_manager_impl.cc b/device/devices_app/usb/device_manager_impl.cc

index 6776438c953a5e69620bd802e3d886ab49eef751..da3681b18d5834c3cf668e56f4fce570b461c8a3 100644

--- a/device/devices_app/usb/device_manager_impl.cc

+++ b/device/devices_app/usb/device_manager_impl.cc

@@ -111,8 +111,9 @@ DeviceManagerImpl::DeviceManagerImpl(

DeviceManagerImpl::~DeviceManagerImpl() {

}

-void DeviceManagerImpl::set_error_handler(mojo::ErrorHandler* error_handler) {

- binding_.set_error_handler(error_handler);

+void DeviceManagerImpl::set_connection_error_handler(

+ const mojo::Closure& error_handler) {

+ binding_.set_connection_error_handler(error_handler);

}

void DeviceManagerImpl::GetDevices(EnumerationOptionsPtr options,

« no previous file with comments | « device/devices_app/usb/device_manager_impl.h ('k') | device/devices_app/usb/device_manager_impl_unittest.cc » ('j') | no next file with comments »