Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: ui/keyboard/keyboard_controller_unittest.cc

Issue 1226123014: Align VK with left edge of screen when shelf is left positioned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/keyboard/keyboard_layout_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/keyboard/keyboard_controller_unittest.cc
diff --git a/ui/keyboard/keyboard_controller_unittest.cc b/ui/keyboard/keyboard_controller_unittest.cc
index 116e43e9ad633b30a747c3c632c32af8fa72d5fa..57680b94d5b5a4ee5f1ba82ecb9b7eb5f1645fef 100644
--- a/ui/keyboard/keyboard_controller_unittest.cc
+++ b/ui/keyboard/keyboard_controller_unittest.cc
@@ -274,7 +274,6 @@ TEST_F(KeyboardControllerTest, KeyboardSize) {
ASSERT_EQ(gfx::Rect(), initial_bounds);
VerifyKeyboardWindowSize(container, keyboard);
- gfx::Rect new_bounds(0, 0, 50, 50);
// In FULL_WIDTH mode, attempt to change window width or move window up from
// the bottom are ignored. Changing window height is supported.
@@ -283,6 +282,10 @@ TEST_F(KeyboardControllerTest, KeyboardSize) {
screen_bounds.width(),
50);
+ // The x position of new bounds may not be 0 if shelf is on the left side of
+ // screen. In FULL_WIDTH mode, the virtual keyboard should always align with
+ // the left edge of screen. See http://crbug.com/510595.
+ gfx::Rect new_bounds(10, 0, 50, 50);
keyboard->SetBounds(new_bounds);
ASSERT_EQ(expected_bounds, container->bounds());
VerifyKeyboardWindowSize(container, keyboard);
« no previous file with comments | « no previous file | ui/keyboard/keyboard_layout_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698