Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp - Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp

Issue 1226123008: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/SVGStrokeDasharrayStyleInterpolation.cpp ('k') | Source/core/animation/ShadowStyleInterpolation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp

diff --git a/Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp b/Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp

index 92b3b49a40d03642fee06be59a40367d5f3fa2a8..2f23d6eb5bffccf02741fd1ac89624d4ed5ad08e 100644

--- a/Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp

+++ b/Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp

@@ -29,7 +29,7 @@ protected:

static void testPrimitiveValue(const CSSValue& cssValue, double value, CSSPrimitiveValue::UnitType unitType)

{

EXPECT_TRUE(cssValue.isPrimitiveValue());

- const CSSPrimitiveValue primitiveValue = toCSSPrimitiveValue(cssValue);

+ const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(cssValue);

EXPECT_EQ(primitiveValue.primitiveType(), unitType);

EXPECT_EQ(primitiveValue.getDoubleValue(), value);