Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: sky/sdk/lib/widgets/fixed_height_scrollable.dart

Issue 1226113007: Add @override annotation to known overriden methods (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/widgets/drawer_header.dart ('k') | sky/sdk/lib/widgets/flat_button.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/widgets/fixed_height_scrollable.dart
diff --git a/sky/sdk/lib/widgets/fixed_height_scrollable.dart b/sky/sdk/lib/widgets/fixed_height_scrollable.dart
index 81cdb20cc9b8c82926eb107271572e3f1eeee935..2a5c1750be4fa24fbe813528305b2c4326929016 100644
--- a/sky/sdk/lib/widgets/fixed_height_scrollable.dart
+++ b/sky/sdk/lib/widgets/fixed_height_scrollable.dart
@@ -24,13 +24,17 @@ abstract class FixedHeightScrollable extends Scrollable {
/// how many items there are in the list.
int get itemCount;
+ @override
void syncFields(FixedHeightScrollable source) {
padding = source.padding;
itemHeight = source.itemHeight;
super.syncFields(source);
}
+ @override
ScrollBehavior createScrollBehavior() => new OverscrollBehavior();
+
+ @override
OverscrollBehavior get scrollBehavior => super.scrollBehavior;
double _height;
@@ -41,6 +45,7 @@ abstract class FixedHeightScrollable extends Scrollable {
});
}
+ @override
bool scrollTo(double newScrollOffset) {
if (_height != null && _height > 0.0) {
double maxScrollOffset = math.max(0.0, itemCount * itemHeight - _height);
@@ -56,6 +61,7 @@ abstract class FixedHeightScrollable extends Scrollable {
scrollBehavior.contentsHeight = contentsHeight;
}
+ @override
Widget buildContent() {
_updateContentsHeight();
« no previous file with comments | « sky/sdk/lib/widgets/drawer_header.dart ('k') | sky/sdk/lib/widgets/flat_button.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698