Issue 12261047: Warn on missing OVERRIDE/virtual everywhere, not just in header files.

Issue 12261047: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed)

Created:
7 years, 10 months ago by Ryan Sleevi

Modified:
7 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Warn on missing OVERRIDE/virtual everywhere, not just in header files. This is only enabled for Linux & ChromiumOS builds. BUG=115047

Patch Set 3 : Enable everywhere #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	tools/clang/scripts/plugin_flags.sh	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

Nico: Beginning the transition to making it a hard warning everywhere.

7 years, 10 months ago (2013-02-14 23:56:25 UTC) #1

Nico

https://codereview.chromium.org/12261047/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/12261047/diff/1/build/common.gypi#newcode1439 build/common.gypi:1439: ], (do you need this branch at all?)

7 years, 10 months ago (2013-02-18 09:42:24 UTC) #3

Ryan Sleevi

7 years, 10 months ago (2013-02-18 09:50:26 UTC) #4

Nico

7 years, 10 months ago (2013-02-18 12:07:41 UTC) #5

https://codereview.chromium.org/12261047/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/12261047/diff/1/build/common.gypi#newcode1439
build/common.gypi:1439: ],
On 2013/02/18 09:50:26, Ryan Sleevi wrote:
> On 2013/02/18 09:42:24, Nico wrote:
> > (do you need this branch at all?)
> 
> Yeah, this brings it out from variable-variable scope to just variable scope.

That's what I guessed.

> GYP is weird, amirite?

variable scoping in gyp is a mystery to me. Looking at the 4-deep variable
stacks in build/common.gypi I can't help but feel that I'm not alone. Do you
understand these rules? If so, would you mind writing them up somewhere, with a
simple guideline how deep nesting has to be under which circumstances?

Expand Messages | Collapse Messages