Warn on missing OVERRIDE/virtual everywhere, not just in header files.

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 1409 matching lines @@
       ['enable_app_list==1', {
         'grit_defines': ['-D', 'enable_app_list'],
       }],
       ['enable_settings_app==1', {
         'grit_defines': ['-D', 'enable_settings_app'],
       }],
       ['enable_google_now==1', {
         'grit_defines': ['-D', 'enable_google_now'],
       }],
       ['clang_use_chrome_plugins==1 and OS!="win"', {
-        'clang_chrome_plugins_flags': [
-          '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)'
+        'variables': {
+          'clang_chrome_plugins_flags': [
+            '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)'
+          ],
+        },
+        'conditions': [
+          ['OS=="linux" or chromeos==1', {
+            'clang_chrome_plugin_flags': [
+              '<@(clang_chrome_plugin_flags)'
+            ],

[Nico, 2013/02/18 09:42:24]

(do you need this branch at all?)

[Ryan Sleevi, 2013/02/18 09:50:26]

Yeah, this brings it out from variable-variable scope to just variable scope.

GYP is weird, amirite?

[Nico, 2013/02/18 12:07:41]

That's what I guessed.
variable scoping in gyp is a mystery to me. Looking at the 4-deep variable
stacks in build/common.gypi I can't help but feel that I'm not alone. Do you
understand these rules? If so, would you mind writing them up somewhere, with a
simple guideline how deep nesting has to be under which circumstances?

+          }, {
+            # TODO(rsleevi): http://crbug.com/115047 - This warning is only
+            # enabled for Linux/ChromiumOS for now. Disable everywhere else.
+            'clang_chrome_plugin_flags': [
+              '<@(clang_chrome_plugin_flags)',
+              '-Xclang',
+              '-plugin-arg-find-bad-constructs',
+              '-Xclang',
+              'skip-virtuals-in-implementations',
+            ],
+          }]
         ],
       }],
 
       ['enable_web_intents_tag==1', {
         'grit_defines': ['-D', 'enable_web_intents_tag'],
       }],
 
       ['asan==1 and OS!="win"', {
         'clang%': 1,
       }],
@@ skipping 2598 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }