Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1226103005: Revert of bluetooth: android: Initial Low Energy Discovery Sessions. (Closed)

Created:
5 years, 5 months ago by scheib
Modified:
5 years, 5 months ago
Reviewers:
Ted C, ortuno, armansito
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bta-manifest-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of bluetooth: android: Initial Low Energy Discovery Sessions. (patchset #9 id:320001 of https://codereview.chromium.org/1150833002/) Reason for revert: Downstream Chrome build encountered runtime errors: java.lang.NoClassDefFoundError: org/chromium/device/bluetooth/ChromeBluetoothAdapter 6a6b6: 07-08 23:04:48.277 3034 3054 W System.err: at org.chromium.base.library_loader.Linker.nativeLoadLibrary(Native Method) 6a6b6: 07-08 23:04:48.277 3034 3054 W System.err: at org.chromium.base.library_loader.Linker.loadLibrary(Linker.java:747) 6a6b6: 07-08 23:04:48.277 3034 3054 W System.err: at org.chromium.base.library_loader.LibraryLoader.loadLibrary(LibraryLoader.java:304) 6a6b6: 07-08 23:04:48.277 3034 3054 W System.err: at org.chromium.base.library_loader.LibraryLoader.loadAlreadyLocked(LibraryLoader.java:241) 6a6b6: 07-08 23:04:48.277 3034 3054 W System.err: at org.chromium.base.library_loader.LibraryLoader.ensureInitialized(LibraryLoader.java:123) 6a6b6: 07-08 23:04:48.277 3034 3054 W System.err: at org.chromium.chrome.browser.init.NativeInitializationController$1.run(NativeInitializationController.java:83) 6a6b6: 07-08 23:04:48.287 3034 3054 W System.err: Caused by: java.lang.ClassNotFoundException: Didn't find class "org.chromium.device.bluetooth.ChromeBluetoothAdapter" on path: DexPathList[[zip file "/system/framework/android.test.runner.jar", zip file "/data/app/com.google.android.apps.chrome.tests-1.apk", zip file "/data/app/com.google.android.apps.chrome-1.apk"],nativeLibraryDirectories=[/data/app-lib/com.google.android.apps.chrome.tests-1, /data/app-lib/com.google.android.apps.chrome-1, /vendor/lib, /system/lib]] 6a6b6: 07-08 23:04:48.287 3034 3054 W System.err: at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:56) 6a6b6: 07-08 23:04:48.287 3034 3054 W System.err: at java.lang.ClassLoader.loadClass(ClassLoader.java:497) 6a6b6: 07-08 23:04:48.287 3034 3054 W System.err: at java.lang.ClassLoader.loadClass(ClassLoader.java:457) Original issue's description: > bluetooth: android: Initial Low Energy Discovery Sessions. > > Add ability to start a low energy scan, though do nothing with the > results for now besides log that they are found. > > Rename hasBluetoothPermission -> hasBluetoothCapability because the > permissions, SDK version, and hardware feature must all be present. > > BUG=488575 > > Committed: https://crrev.com/649ce43ef16cd8c4a3315f2ebfa5823dcc06585e > Cr-Commit-Position: refs/heads/master@{#337924} TBR=ortuno@chromium.org,tedchoc@chromium.org,armansito@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488575 Committed: https://crrev.com/66d38d303c389e2a8390a63353e51df6076fb47f Cr-Commit-Position: refs/heads/master@{#337955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -481 lines) Patch
M chrome/android/shell/java/AndroidManifest.xml.jinja2 View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothAdapter.java View 4 chunks +4 lines, -145 lines 0 comments Download
M device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java View 6 chunks +2 lines, -148 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_android.h View 2 chunks +0 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_android.cc View 2 chunks +3 lines, -23 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_unittest.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java View 4 chunks +1 line, -79 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.h View 2 chunks +0 lines, -20 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.cc View 2 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheib
Created Revert of bluetooth: android: Initial Low Energy Discovery Sessions.
5 years, 5 months ago (2015-07-09 00:43:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226103005/1
5 years, 5 months ago (2015-07-09 00:44:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 00:46:27 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 00:47:30 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66d38d303c389e2a8390a63353e51df6076fb47f
Cr-Commit-Position: refs/heads/master@{#337955}

Powered by Google App Engine
This is Rietveld 408576698