Issue 1226063007: Enable new media playback UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1226063007: Enable new media playback UI.

Created:
5 years, 5 months ago by liberato (no reviews please)

Modified:
5 years, 5 months ago

Reviewers:

Base URL:
https://chromium.googlesource.com/chromium/blink.git@newux3

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Enable new media playback UI. Enables new media playback UI by default. Requires that https://codereview.chromium.org/1156993013/ is landed first. This CL also marks the affected layout tests for the rebaseline-o-matic. BUG=446350, 488625, 487344

Patch Set 1 #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -8 lines)			Patch
M	LayoutTests/TestExpectations	View	3 chunks	+65 lines, -3 lines	0 comments	Download
M	LayoutTests/media/track/track-cue-container-rendering-position.html	View	1 chunk	+2 lines, -2 lines	1 comment	Download
M	LayoutTests/media/track/track-cue-container-rendering-position-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/platform/RuntimeEnabledFeatures.in	View	1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 1156993013 Patch 870001

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

liberato (no reviews please)

5 years, 5 months ago (2015-07-14 22:18:57 UTC) #4

https://codereview.chromium.org/1226063007/diff/1/LayoutTests/media/track/tra...
File LayoutTests/media/track/track-cue-container-rendering-position.html (left):

https://codereview.chromium.org/1226063007/diff/1/LayoutTests/media/track/tra...
LayoutTests/media/track/track-cue-container-rendering-position.html:24:
testExpected("cueDisplayElement.offsetTop > (video.videoHeight * .75)", true);
this is changed because the bar is higher.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages