Issue 12260019: Add pre-commit hook to disallow submodule changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12260019: Add pre-commit hook to disallow submodule changes. (Closed)

Created:
7 years, 10 months ago by szager1

Modified:
7 years, 9 months ago

Reviewers:
cmp, iannucci

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add pre-commit hook to disallow submodule changes. TBR=cmp@chromium.org,iannucci@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182555

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -0 lines)			Patch
	A	build/git-hooks/pre-commit	View		1 chunk	+34 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

iannucci

7 years, 9 months ago (2013-02-28 01:48:17 UTC) #2

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/12260019/diff/1/build/git-hooks/pre-commit
File build/git-hooks/pre-commit (right):

https://codereview.chromium.org/12260019/diff/1/build/git-hooks/pre-commit#ne...
build/git-hooks/pre-commit:10: Submodule commits are not allowed.  Please run:
It might be nice to revise this to indicate that they don't work because they're
non-sensical under the current git model, not because of policy.

Expand Messages | Collapse Messages