Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: build/git-hooks/pre-commit

Issue 12260019: Add pre-commit hook to disallow submodule changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 #!/bin/bash
2
3 submods=$(git diff-index --cached --ignore-submodules=dirty HEAD | grep -e '^:16 0000' -e '^:...... 160000' | xargs)
4 if test "$submods"; then
5 echo "You are trying to commit changes to the following submodules:" 1>&2
6 echo 1>&2
7 echo $submods | cut -d ' ' -f 6 | sed 's/^/ /g' 1>&2
8 cat <<EOF 1>&2
9
10 Submodule commits are not allowed. Please run:
iannucci 2013/02/28 01:48:17 It might be nice to revise this to indicate that t
11
12 git status --ignore-submodules=dirty
13
14 and/or:
15
16 git diff-index --cached --ignore-submodules=dirty HEAD
17
18 ... to see what's in your index.
19
20 If you're really and truly trying to roll the version of a submodule, you should
21 commit the new version to DEPS, instead.
22 EOF
23 exit 1
24 fi
25
26 if test "$(git diff-index --cached HEAD .gitmodules)"; then
27 cat <<EOF 1>&2
28 You are trying to commit a change to .gitmodules. That is not allowed.
29 To make changes to submodule names/paths, edit DEPS.
30 EOF
31 exit 1
32 fi
33
34 exit 0
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698