Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Issue 1225993002: [turbofan] Add TruncationMode for TruncateFloat64ToInt32. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add TruncationMode for TruncateFloat64ToInt32. We actually need round to zero truncation to implement the counterpart of LDoubleToI in TurboFan, which tries to convert a double to an integer as required for keyed load/store optimizations. Drive-by-cleanup: Reduce some code duplication in the InstructionSelector implementations. R=jarin@chromium.org Committed: https://crrev.com/4b38c15817033ccd9a65efbb3d038ae2423293c2 Cr-Commit-Position: refs/heads/master@{#29527}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -159 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +12 lines, -3 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 3 chunks +24 lines, -20 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/machine-operator.h View 3 chunks +20 lines, -3 lines 0 comments Download
M src/compiler/machine-operator.cc View 4 chunks +45 lines, -1 line 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/representation-change.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 3 chunks +11 lines, -4 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 4 chunks +54 lines, -47 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 4 chunks +23 lines, -61 lines 0 comments Download
M test/unittests/compiler/machine-operator-unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
Benedikt Meurer
5 years, 5 months ago (2015-07-08 05:41:23 UTC) #1
Benedikt Meurer
Hey Jaro, This adds a new truncation mode for TruncateFloat64ToInt32 (in addition to the JavaScript ...
5 years, 5 months ago (2015-07-08 05:43:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225993002/1
5 years, 5 months ago (2015-07-08 06:27:04 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-08 06:28:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225993002/1
5 years, 5 months ago (2015-07-08 06:28:54 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 5 months ago (2015-07-08 06:28:56 UTC) #10
Jarin
lgtm. (I am not wild about the VisitRR, VisitRO names, but I see that is ...
5 years, 5 months ago (2015-07-08 06:45:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225993002/1
5 years, 5 months ago (2015-07-08 06:47:15 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-08 06:48:58 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 06:49:14 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b38c15817033ccd9a65efbb3d038ae2423293c2
Cr-Commit-Position: refs/heads/master@{#29527}

Powered by Google App Engine
This is Rietveld 408576698