Reland: Add unoptimized/optimized variants of MathFloor TF code stub

Reland: Add unoptimized/optimized variants of MathFloor TF code stub

- Add a TurboFanIC class, derived from TurboFanCodeStub, that
  automatically distinguishes between versions of the IC called from
  optimized and unoptimized code.
- Add appropriate InterfaceDescriptors for both the versions of the
  stub called from unoptimized and optimized code
- Change the MathFloor TF stub generator to output either the
  for-optimized or for-unoptimized version based on the minor_key
  parameter.

Committed: https://crrev.com/8f13b655b8a10dae2116dd18b32f09337bb2d410
Cr-Commit-Position: refs/heads/master@{#29534}

Committed: https://crrev.com/737b8573f80deaa1cbaec98f42ecd3e3b56ba901
Cr-Commit-Position: refs/heads/master@{#29539}

[danno, 2015-07-08 08:33:44]

danno@chromium.org changed reviewers:
+ bmeurer@chromium.org, mvstanton@chromium.org

[danno, 2015-07-08 08:33:57]

PTAL

[mvstanton, 2015-07-08 09:42:29]

LGTM modulo a couple comments. Nice to see this coming together!

https://codereview.chromium.org/1225943002/diff/20001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/1225943002/diff/20001/src/code-stubs.h#newcod...
src/code-stubs.h:102: V(MathFloor)                              \
Why is this now listed as an IC handler stub?

https://codereview.chromium.org/1225943002/diff/20001/src/runtime.js
File src/runtime.js (right):

https://codereview.chromium.org/1225943002/diff/20001/src/runtime.js#newcode796
src/runtime.js:796: %_FixedArraySet(tv, ((i|0)+1)|0, 1);
It would be cool if expressions like ((i|0)+1)|0 could live in a macro,
especially as we create more of these excellent turbofan code stubs.

[Benedikt Meurer, 2015-07-08 12:21:30]

LGTM.

[danno, 2015-07-08 13:08:40]

Feedback addressed.

https://codereview.chromium.org/1225943002/diff/20001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/1225943002/diff/20001/src/code-stubs.h#newcod...
src/code-stubs.h:102: V(MathFloor)                              \
On 2015/07/08 09:42:29, mvstanton wrote:
> Why is this now listed as an IC handler stub? 

Done.

https://codereview.chromium.org/1225943002/diff/20001/src/runtime.js
File src/runtime.js (right):

https://codereview.chromium.org/1225943002/diff/20001/src/runtime.js#newcode796
src/runtime.js:796: %_FixedArraySet(tv, ((i|0)+1)|0, 1);
On 2015/07/08 09:42:29, mvstanton wrote:
> It would be cool if expressions like ((i|0)+1)|0 could live in a macro,
> especially as we create more of these excellent turbofan code stubs.

Acknowledged.

[danno, 2015-07-08 13:09:37]

The CQ bit was checked by danno@chromium.org

[danno, 2015-07-08 13:09:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/1225943002/#ps40001
(title: "Review feedback")

[commit-bot: I haz the power, 2015-07-08 13:09:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1225943002/40001

[commit-bot: I haz the power, 2015-07-08 13:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 13:19:38]

Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/7528)

(exceeded global retry quota)

[danno, 2015-07-08 14:05:44]

The CQ bit was checked by danno@chromium.org

[danno, 2015-07-08 14:05:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/1225943002/#ps60001
(title: "Remove bogus test")

[commit-bot: I haz the power, 2015-07-08 14:05:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1225943002/60001

[commit-bot: I haz the power, 2015-07-08 14:43:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-08 14:43:40]

Patchset 4 (id:??) landed as
https://crrev.com/8f13b655b8a10dae2116dd18b32f09337bb2d410
Cr-Commit-Position: refs/heads/master@{#29534}

[danno, 2015-07-08 15:00:10]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1220783006/ by danno@chromium.org.

The reason for reverting is: Failure on compiling runtime.js on windows.

[danno, 2015-07-08 16:27:17]

The CQ bit was checked by danno@chromium.org

[danno, 2015-07-08 16:27:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/1225943002/#ps80001
(title: "Fix nosnap bug")

[commit-bot: I haz the power, 2015-07-08 16:27:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1225943002/80001

[commit-bot: I haz the power, 2015-07-08 16:53:38]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-07-08 16:54:03]

Patchset 5 (id:??) landed as
https://crrev.com/737b8573f80deaa1cbaec98f42ecd3e3b56ba901
Cr-Commit-Position: refs/heads/master@{#29539}