Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1441)

Unified Diff: net/spdy/spdy_protocol.h

Issue 12259004: Remove SpdyPingControlFrame struct. Useful for SPDY 4 development. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_framer_test.cc ('k') | net/spdy/spdy_protocol_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_protocol.h
diff --git a/net/spdy/spdy_protocol.h b/net/spdy/spdy_protocol.h
index 1cc19940282168b31327776cfe26237ae4fe383f..dd7e7534ada60111009ffbe074061349ee672ed4 100644
--- a/net/spdy/spdy_protocol.h
+++ b/net/spdy/spdy_protocol.h
@@ -503,11 +503,6 @@ struct SpdySettingsControlFrameBlock : SpdyFrameBlock {
// Variable data here.
};
-// A PING Control Frame structure.
-struct SpdyPingControlFrameBlock : SpdyFrameBlock {
- uint32 unique_id_;
-};
-
// TODO(avd): remove this struct
// A CREDENTIAL Control Frame structure.
struct SpdyCredentialControlFrameBlock : SpdyFrameBlock {
@@ -1112,31 +1107,6 @@ class SpdySettingsControlFrame : public SpdyControlFrame {
DISALLOW_COPY_AND_ASSIGN(SpdySettingsControlFrame);
};
-class SpdyPingControlFrame : public SpdyControlFrame {
- public:
- SpdyPingControlFrame() : SpdyControlFrame(size()) {}
- SpdyPingControlFrame(char* data, bool owns_buffer)
- : SpdyControlFrame(data, owns_buffer) {}
-
- uint32 unique_id() const {
- return ntohl(block()->unique_id_);
- }
-
- void set_unique_id(uint32 unique_id) {
- mutable_block()->unique_id_ = htonl(unique_id);
- }
-
- static size_t size() { return sizeof(SpdyPingControlFrameBlock); }
-
- private:
- const struct SpdyPingControlFrameBlock* block() const {
- return static_cast<SpdyPingControlFrameBlock*>(frame_);
- }
- struct SpdyPingControlFrameBlock* mutable_block() {
- return static_cast<SpdyPingControlFrameBlock*>(frame_);
- }
-};
-
class SpdyCredentialControlFrame : public SpdyControlFrame {
public:
SpdyCredentialControlFrame() : SpdyControlFrame(size()) {}
« no previous file with comments | « net/spdy/spdy_framer_test.cc ('k') | net/spdy/spdy_protocol_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698