Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Unified Diff: net/spdy/spdy_protocol_test.cc

Issue 12259004: Remove SpdyPingControlFrame struct. Useful for SPDY 4 development. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_protocol.h ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_protocol_test.cc
diff --git a/net/spdy/spdy_protocol_test.cc b/net/spdy/spdy_protocol_test.cc
index 5d92dcff1a2e6aec76ed63c46c1293dc60345ee6..aa4b345e9107170d37d2c8a9f627e1f38a222f38 100644
--- a/net/spdy/spdy_protocol_test.cc
+++ b/net/spdy/spdy_protocol_test.cc
@@ -46,7 +46,6 @@ TEST_P(SpdyProtocolTest, ProtocolConstants) {
EXPECT_EQ(18u, SpdySynStreamControlFrame::size());
EXPECT_EQ(16u, SpdyRstStreamControlFrame::size());
EXPECT_EQ(12u, SpdySettingsControlFrame::size());
- EXPECT_EQ(12u, SpdyPingControlFrame::size());
EXPECT_EQ(12u, SpdyHeadersControlFrame::size());
EXPECT_EQ(4u, sizeof(FlagsAndLength));
EXPECT_EQ(1, SYN_STREAM);
@@ -114,17 +113,6 @@ TEST_P(SpdyProtocolTest, ControlFrameStructs) {
EXPECT_EQ(net::RST_STREAM_INVALID_STREAM, rst_frame->status());
EXPECT_EQ(0, rst_frame->flags());
- const uint32 kUniqueId = 1234567u;
- const uint32 kUniqueId2 = 31415926u;
- scoped_ptr<SpdyPingControlFrame> ping_frame(
- framer.CreatePingFrame(kUniqueId));
- EXPECT_EQ(framer.protocol_version(), ping_frame->version());
- EXPECT_TRUE(ping_frame->is_control_frame());
- EXPECT_EQ(PING, ping_frame->type());
- EXPECT_EQ(kUniqueId, ping_frame->unique_id());
- ping_frame->set_unique_id(kUniqueId2);
- EXPECT_EQ(kUniqueId2, ping_frame->unique_id());
-
scoped_ptr<SpdyHeadersControlFrame> headers_frame(
framer.CreateHeaders(123, CONTROL_FLAG_NONE, false, &headers));
EXPECT_EQ(framer.protocol_version(), headers_frame->version());
« no previous file with comments | « net/spdy/spdy_protocol.h ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698