third_party/libjingle/libjingle.gyp - Issue 12258039: enable -Wstring-conversion when compiling with clang

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libjingle/libjingle.gyp

Issue 12258039: enable -Wstring-conversion when compiling with clang (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: enable warning, fix some locations, disable for some subprojects Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libjingle/libjingle.gyp

diff --git a/third_party/libjingle/libjingle.gyp b/third_party/libjingle/libjingle.gyp

index c32500df6ba0fd345d02e6539d0cb05e173d7ff0..2c7dfaf6b0c4395846bff47d2fd942027397ba8f 100644

--- a/third_party/libjingle/libjingle.gyp

+++ b/third_party/libjingle/libjingle.gyp

@@ -180,6 +180,17 @@

}],

+ ['clang == 1', {

+ 'xcode_settings': {

+ 'WARNING_CFLAGS!': [

+ # Don't warn about string->bool used in asserts.

+ '-Wstring-conversion',

+ ],

+ },

+ 'cflags!': [

+ '-Wstring-conversion',

+ ],

+ }],

['OS=="linux"', {

'defines': [

'LINUX',