Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1225733002: Reland concurrent sweeping of code space. (Closed)

Created:
5 years, 5 months ago by Hannes Payer (out of office)
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland concurrent sweeping of code space. BUG=chromium:506778, chromium:506957, chromium:507211 LOG=n Committed: https://crrev.com/806b81f11e3bfaef0d4330c7669e6934074be9cb Cr-Commit-Position: refs/heads/master@{#29748}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -37 lines) Patch
M src/frames.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download
M src/heap/mark-compact.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 12 chunks +77 lines, -27 lines 0 comments Download
M src/heap/store-buffer.cc View 1 2 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Hannes Payer (out of office)
5 years, 5 months ago (2015-07-06 09:50:30 UTC) #2
mvstanton
lgtm
5 years, 5 months ago (2015-07-06 09:51:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225733002/80001
5 years, 5 months ago (2015-07-20 10:34:55 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 5 months ago (2015-07-20 10:36:41 UTC) #7
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/806b81f11e3bfaef0d4330c7669e6934074be9cb Cr-Commit-Position: refs/heads/master@{#29748}
5 years, 5 months ago (2015-07-20 10:36:58 UTC) #8
Hannes Payer (out of office)
5 years, 5 months ago (2015-07-20 12:06:49 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1242743002/ by hpayer@chromium.org.

The reason for reverting is: Tests became flaky..

Powered by Google App Engine
This is Rietveld 408576698