Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: src/frames.cc

Issue 1225733002: Reland concurrent sweeping of code space. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/frames.h" 5 #include "src/frames.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/v8.h" 9 #include "src/v8.h"
10 10
(...skipping 1428 matching lines...) Expand 10 before | Expand all | Expand 10 after
1439 // Check if the inner pointer points into a large object chunk. 1439 // Check if the inner pointer points into a large object chunk.
1440 LargePage* large_page = heap->lo_space()->FindPage(inner_pointer); 1440 LargePage* large_page = heap->lo_space()->FindPage(inner_pointer);
1441 if (large_page != NULL) { 1441 if (large_page != NULL) {
1442 return GcSafeCastToCode(large_page->GetObject(), inner_pointer); 1442 return GcSafeCastToCode(large_page->GetObject(), inner_pointer);
1443 } 1443 }
1444 1444
1445 // Iterate through the page until we reach the end or find an object starting 1445 // Iterate through the page until we reach the end or find an object starting
1446 // after the inner pointer. 1446 // after the inner pointer.
1447 Page* page = Page::FromAddress(inner_pointer); 1447 Page* page = Page::FromAddress(inner_pointer);
1448 1448
1449 DCHECK(page->owner() == heap->code_space());
1450 heap->mark_compact_collector()->EnsureSweepingCompleted(
1451 page, reinterpret_cast<PagedSpace*>(page->owner()));
1452
1449 Address addr = page->skip_list()->StartFor(inner_pointer); 1453 Address addr = page->skip_list()->StartFor(inner_pointer);
1450 1454
1451 Address top = heap->code_space()->top(); 1455 Address top = heap->code_space()->top();
1452 Address limit = heap->code_space()->limit(); 1456 Address limit = heap->code_space()->limit();
1453 1457
1454 while (true) { 1458 while (true) {
1455 if (addr == top && addr != limit) { 1459 if (addr == top && addr != limit) {
1456 addr = limit; 1460 addr = limit;
1457 continue; 1461 continue;
1458 } 1462 }
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
1551 for (StackFrameIterator it(isolate); !it.done(); it.Advance()) { 1555 for (StackFrameIterator it(isolate); !it.done(); it.Advance()) {
1552 StackFrame* frame = AllocateFrameCopy(it.frame(), zone); 1556 StackFrame* frame = AllocateFrameCopy(it.frame(), zone);
1553 list.Add(frame, zone); 1557 list.Add(frame, zone);
1554 } 1558 }
1555 return list.ToVector(); 1559 return list.ToVector();
1556 } 1560 }
1557 1561
1558 1562
1559 } // namespace internal 1563 } // namespace internal
1560 } // namespace v8 1564 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698