Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 12257014: Revert 182281 - Broke Chome Frame tests. (Closed)

Created:
7 years, 10 months ago by Sergey Ulanov
Modified:
7 years, 10 months ago
Reviewers:
ananta
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

Revert 182281 - Broke Chome Frame tests. > Ensure that when themes in desktop chrome AURA on Windows use the opaque browser frame view. > > To achieve this we need to mimic the implementation in BrowserFrameWin::ShouldUseNativeFrame in the > DesktopBrowserFrameAura::ShouldUseNativeFrame override. > > The code in BrowserFrameWin::ShouldUseNativeFrame has been moved to a helper function in the browser namespace > ShouldUseNativeFrame in the newly added files browser_frame_common_win.h/.cc. This is invoked from BrowserFrameWin > and from the BrowserDesktopRootWindowHostWin::ShouldUseNativeFrame override which is invoked via the > DesktopBrowserFrameAura::ShouldUseNativeFrame override for AURA > > BUG=175372 > R=sky > Review URL: https://codereview.chromium.org/12251010 TBR=ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -83 lines) Patch
M chrome/browser/ui/views/frame/browser_desktop_root_window_host_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_desktop_root_window_host_win.cc View 3 chunks +0 lines, -8 lines 0 comments Download
D chrome/browser/ui/views/frame/browser_frame_common_win.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/ui/views/frame/browser_frame_common_win.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_win.cc View 2 chunks +15 lines, -4 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Sergey Ulanov
7 years, 10 months ago (2013-02-13 20:04:24 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698