Ensure that when themes in desktop chrome AURA on Windows use the opaque browser frame view.

Ensure that when themes in desktop chrome AURA on Windows use the opaque browser frame view.

To achieve this we need to mimic the implementation in BrowserFrameWin::ShouldUseNativeFrame in the
DesktopBrowserFrameAura::ShouldUseNativeFrame override.

The code in BrowserFrameWin::ShouldUseNativeFrame has been moved to a helper function in the browser namespace
ShouldUseNativeFrame in the newly added files browser_frame_common_win.h/.cc. This is invoked from BrowserFrameWin
and from the BrowserDesktopRootWindowHostWin::ShouldUseNativeFrame override which is invoked via the
DesktopBrowserFrameAura::ShouldUseNativeFrame override for AURA

BUG=175372
R=sky
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182281

[sky, 2013-02-13 00:42:54]

https://codereview.chromium.org/12251010/diff/5002/chrome/browser/ui/views/fr...
File chrome/browser/ui/views/frame/browser_frame_common_win.h (right):

https://codereview.chromium.org/12251010/diff/5002/chrome/browser/ui/views/fr...
chrome/browser/ui/views/frame/browser_frame_common_win.h:21: namespace browser {
browser->chrome

https://codereview.chromium.org/12251010/diff/5002/chrome/browser/ui/views/fr...
File chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc (right):

https://codereview.chromium.org/12251010/diff/5002/chrome/browser/ui/views/fr...
chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc:95: #if
!defined(OS_WIN)
Can you forward this to browser_desktop_root_window_host_ so we don't need the
ifdefs here?

[ananta, 2013-02-13 01:43:21]

https://codereview.chromium.org/12251010/diff/5002/chrome/browser/ui/views/fr...
File chrome/browser/ui/views/frame/browser_frame_common_win.h (right):

https://codereview.chromium.org/12251010/diff/5002/chrome/browser/ui/views/fr...
chrome/browser/ui/views/frame/browser_frame_common_win.h:21: namespace browser {
On 2013/02/13 00:42:54, sky wrote:
> browser->chrome

Done.

https://codereview.chromium.org/12251010/diff/5002/chrome/browser/ui/views/fr...
File chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc (right):

https://codereview.chromium.org/12251010/diff/5002/chrome/browser/ui/views/fr...
chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc:95: #if
!defined(OS_WIN)
On 2013/02/13 00:42:54, sky wrote:
> Can you forward this to browser_desktop_root_window_host_ so we don't need the
> ifdefs here?

I removed this method which achieves what you described. The 
DesktopNativeWidgetAura::ShouldUseNativeFrame override already does this, i.e.
forwards it off to the desktop_root_window_host_. I added a windows specific
implementation of this function in the BrowserDesktopRootWindowHostWin which
forwards it off to the chrome::ShouldUseNativeFrameHelper.

PTAL.

[sky, 2013-02-13 14:49:44]

LGTM

https://codereview.chromium.org/12251010/diff/11014/ui/views/widget/desktop_a...
File ui/views/widget/desktop_aura/desktop_root_window_host_win.h (right):

https://codereview.chromium.org/12251010/diff/11014/ui/views/widget/desktop_a...
ui/views/widget/desktop_aura/desktop_root_window_host_win.h:203: const
DesktopNativeWidgetAura* desktop_native_widget_aura() {
This should be:
const DesktopNativeWidgetAura* desktop_native_widget_aura() const;

and if you need it add:
DesktopNativeWidgetAura* desktop_native_widget_aura()

[ananta, 2013-02-13 19:07:58]

https://codereview.chromium.org/12251010/diff/11014/ui/views/widget/desktop_a...
File ui/views/widget/desktop_aura/desktop_root_window_host_win.h (right):

https://codereview.chromium.org/12251010/diff/11014/ui/views/widget/desktop_a...
ui/views/widget/desktop_aura/desktop_root_window_host_win.h:203: const
DesktopNativeWidgetAura* desktop_native_widget_aura() {
On 2013/02/13 14:49:44, sky wrote:
> This should be:
> const DesktopNativeWidgetAura* desktop_native_widget_aura() const;
> 
> and if you need it add:
> DesktopNativeWidgetAura* desktop_native_widget_aura()

Done.

[Sergey Ulanov, 2013-02-13 20:22:59]

Reverted because it was breaking many tests on windows. Please make sure your
try results are *green* before landing this again. There were many repeated
failing tests in you try jobs and you landed it anyway.