Issue 12257005: Improve JSON stringifier's escape check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12257005: Improve JSON stringifier's escape check. (Closed)

Created:
7 years, 10 months ago by Yang

Modified:
7 years, 10 months ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Improve JSON stringifier's escape check. BUG=

Patch Set 1 #

Patch Set 2 : reduce impact on the scanner. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -57 lines)			Patch
M	include/v8.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/heap.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/json-stringifier.h	View		15 chunks	+42 lines, -32 lines	0 comments	Download
M	src/parser.cc	View		4 chunks	+10 lines, -4 lines	0 comments	Download
M	src/preparser.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/scanner.h	View	1	6 chunks	+33 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

On 2013/02/13 12:05:16, Yang wrote: > Please take a look. I uploaded a patch set ...

7 years, 10 months ago (2013-02-13 12:27:15 UTC) #2

Yang

7 years, 10 months ago (2013-02-13 14:49:14 UTC) #3

On 2013/02/13 12:27:15, Yang wrote:
> On 2013/02/13 12:05:16, Yang wrote:
> > Please take a look.
> 
> I uploaded a patch set to reduce the performance impact on the scanner.

Abandoned in favor of https://codereview.chromium.org/12207153/

Expand Messages | Collapse Messages