src/preparser.cc - Issue 12257005: Improve JSON stringifier's escape check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/preparser.cc

Issue 12257005: Improve JSON stringifier's escape check. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: reduce impact on the scanner. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/preparser.cc

diff --git a/src/preparser.cc b/src/preparser.cc

index 21da4f80d418cb31d6d9e1c8bdbd4e3972d6be5e..4451cf23513f117321acae8f2cda1825b8b0ebd0 100644

--- a/src/preparser.cc

+++ b/src/preparser.cc

@@ -1637,7 +1637,7 @@ PreParser::Identifier PreParser::ParseIdentifierNameOrGetOrSet(bool* is_get,

bool* ok) {

Identifier result = ParseIdentifierName(ok);

if (!*ok) return Identifier::Default();

- if (scanner_->is_literal_ascii() &&

+ if (scanner_->is_literal_printable_ascii() &&

scanner_->literal_length() == 3) {

const char* token = scanner_->literal_ascii_string().start();

*is_get = strncmp(token, "get", 3) == 0;

« no previous file with comments | « src/parser.cc ('k') | src/scanner.h » ('j') | no next file with comments »