Fix a bug where extensions created with locale info from the command line is broken.

chrome/browser/extensions/pack_extension_job.cc

Index: chrome/browser/extensions/pack_extension_job.cc
diff --git a/chrome/browser/extensions/pack_extension_job.cc b/chrome/browser/extensions/pack_extension_job.cc
index fc85098079dcaa5dc7fa919426ebf30680cf4f90..31c78c94eb1a90b06b89e9a59b9edaaeec44b35a 100644
--- a/chrome/browser/extensions/pack_extension_job.cc
+++ b/chrome/browser/extensions/pack_extension_job.cc
@@ -10,6 +10,9 @@
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_creator.h"
 #include "chrome/common/chrome_constants.h"
+#include "chrome/common/extensions/api/i18n/default_locale_handler.h"
+#include "chrome/common/extensions/extension_manifest_constants.h"
+#include "chrome/common/extensions/manifest_handler.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
@@ -25,6 +28,8 @@ PackExtensionJob::PackExtensionJob(Client* client,
       run_flags_(run_flags | ExtensionCreator::kRequireModernManifestVersion) {
   root_directory_ = root_directory.StripTrailingSeparators();
   CHECK(BrowserThread::GetCurrentThreadIdentifier(&client_thread_id_));
+  ManifestHandler::Register(extension_manifest_keys::kDefaultLocale,
+                            make_linked_ptr(new DefaultLocaleHandler));

[Joe Thomas, 2013/02/14 18:14:42]

We can also move this registration to StartupHelper::PackExtension to make it
specific to the failing test case. But for me having it here looks better.

[Yoyo Zhou, 2013/02/14 18:41:02]

I think it belongs in StartupHelper, probably the constructor.

PackExtensionJob can also be invoked from the chrome UI, in which case the
handler should already be registered.

[Joe Thomas, 2013/02/14 18:48:47]

I thought about that. Then I found that we just destroy the old ManifestHandler
and replace it with new one. So I add the code in PackExtensionJob constructor.

Anyways I will move it to  StartupHelper c'tor.

[Joe Thomas, 2013/02/14 19:16:28]

Done.

 }
 
 void PackExtensionJob::Start() {