Fix a bug where extensions created with locale info from the command line is broken.

chrome/browser/extensions/pack_extension_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/pack_extension_job.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/sys_string_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_creator.h"
 #include "chrome/common/chrome_constants.h"
+#include "chrome/common/extensions/api/i18n/default_locale_handler.h"
+#include "chrome/common/extensions/extension_manifest_constants.h"
+#include "chrome/common/extensions/manifest_handler.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 using content::BrowserThread;
 
 namespace extensions {
 
 PackExtensionJob::PackExtensionJob(Client* client,
                                    const base::FilePath& root_directory,
                                    const base::FilePath& key_file,
                                    int run_flags)
     : client_(client), key_file_(key_file), asynchronous_(true),
       run_flags_(run_flags | ExtensionCreator::kRequireModernManifestVersion) {
   root_directory_ = root_directory.StripTrailingSeparators();
   CHECK(BrowserThread::GetCurrentThreadIdentifier(&client_thread_id_));
+  ManifestHandler::Register(extension_manifest_keys::kDefaultLocale,
+                            make_linked_ptr(new DefaultLocaleHandler));

[Joe Thomas, 2013/02/14 18:14:42]

We can also move this registration to StartupHelper::PackExtension to make it
specific to the failing test case. But for me having it here looks better.

[Yoyo Zhou, 2013/02/14 18:41:02]

I think it belongs in StartupHelper, probably the constructor.

PackExtensionJob can also be invoked from the chrome UI, in which case the
handler should already be registered.

[Joe Thomas, 2013/02/14 18:48:47]

I thought about that. Then I found that we just destroy the old ManifestHandler
and replace it with new one. So I add the code in PackExtensionJob constructor.

Anyways I will move it to  StartupHelper c'tor.

[Joe Thomas, 2013/02/14 19:16:28]

Done.

 }
 
 void PackExtensionJob::Start() {
   if (asynchronous_) {
     BrowserThread::PostTask(
         BrowserThread::FILE, FROM_HERE,
         base::Bind(&PackExtensionJob::Run, this));
   } else {
     Run();
   }
@@ skipping 63 matching lines @@
         crx_file_string);
   } else {
     return l10n_util::GetStringFUTF16(
         IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY_NEW,
         crx_file_string,
         key_file_string);
   }
 }
 
 }  // namespace extensions