Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12256004: Remove SpdySynReplyControlFrame and SpdyGoAwayControlFrame. (Closed)

Created:
7 years, 10 months ago by akalin
Modified:
7 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove SpdySynReplyControlFrame and SpdyGoAwayControlFrame. Useful in SPDY 4 development. This lands server change 420065749. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -189 lines) Patch
M net/spdy/buffered_spdy_framer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/buffered_spdy_framer_spdy2_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/buffered_spdy_framer_spdy3_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_frame_reader.h View 3 chunks +18 lines, -0 lines 0 comments Download
M net/spdy/spdy_frame_reader.cc View 4 chunks +40 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.h View 3 chunks +10 lines, -8 lines 0 comments Download
M net/spdy/spdy_framer.cc View 7 chunks +47 lines, -36 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 3 chunks +24 lines, -10 lines 0 comments Download
M net/spdy/spdy_protocol.h View 2 chunks +0 lines, -42 lines 0 comments Download
M net/spdy/spdy_protocol_test.cc View 2 chunks +0 lines, -81 lines 0 comments Download
M net/tools/flip_server/spdy_interface.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
akalin
+rch for review
7 years, 10 months ago (2013-02-13 10:07:50 UTC) #1
Ryan Hamilton
lgtm
7 years, 10 months ago (2013-02-13 16:27:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/12256004/1
7 years, 10 months ago (2013-02-13 22:42:56 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) aura_unittests, browser_tests, compositor_unittests, content_browsertests, content_unittests, interactive_ui_tests, ...
7 years, 10 months ago (2013-02-13 23:13:25 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 03:18:34 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698