Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2569)

Unified Diff: net/spdy/spdy_protocol.h

Issue 12256004: Remove SpdySynReplyControlFrame and SpdyGoAwayControlFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_framer_test.cc ('k') | net/spdy/spdy_protocol_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_protocol.h
diff --git a/net/spdy/spdy_protocol.h b/net/spdy/spdy_protocol.h
index e9faa24d445c40665f2be67617d8a329441c80a3..a1a681589981183bd4062b6db412fd5b066e8d94 100644
--- a/net/spdy/spdy_protocol.h
+++ b/net/spdy/spdy_protocol.h
@@ -523,12 +523,6 @@ struct SpdyCredentialControlFrameBlock : SpdyFrameBlock {
// for each certificate: unit32 certificate_len + certificate_data[i]
};
-// A GOAWAY Control Frame structure.
-struct SpdyGoAwayControlFrameBlock : SpdyFrameBlock {
- SpdyStreamId last_accepted_stream_id_;
- SpdyGoAwayStatus status_;
-};
-
// A HEADERS Control Frame structure.
struct SpdyHeadersControlFrameBlock : SpdyFrameBlock {
SpdyStreamId stream_id_;
@@ -1216,42 +1210,6 @@ class SpdyCredentialControlFrame : public SpdyControlFrame {
DISALLOW_COPY_AND_ASSIGN(SpdyCredentialControlFrame);
};
-class SpdyGoAwayControlFrame : public SpdyControlFrame {
- public:
- SpdyGoAwayControlFrame() : SpdyControlFrame(size()) {}
- SpdyGoAwayControlFrame(char* data, bool owns_buffer)
- : SpdyControlFrame(data, owns_buffer) {}
-
- SpdyStreamId last_accepted_stream_id() const {
- return ntohl(block()->last_accepted_stream_id_) & kStreamIdMask;
- }
-
- SpdyGoAwayStatus status() const {
- if (version() < 3) {
- LOG(DFATAL) << "Attempted to access status of SPDY 2 GOAWAY.";
- return GOAWAY_INVALID;
- } else {
- uint32 status = ntohl(block()->status_);
- if (status >= GOAWAY_NUM_STATUS_CODES) {
- return GOAWAY_INVALID;
- } else {
- return static_cast<SpdyGoAwayStatus>(status);
- }
- }
- }
-
- static size_t size() { return sizeof(SpdyGoAwayControlFrameBlock); }
-
- private:
- const struct SpdyGoAwayControlFrameBlock* block() const {
- return static_cast<SpdyGoAwayControlFrameBlock*>(frame_);
- }
- struct SpdyGoAwayControlFrameBlock* mutable_block() {
- return static_cast<SpdyGoAwayControlFrameBlock*>(frame_);
- }
- DISALLOW_COPY_AND_ASSIGN(SpdyGoAwayControlFrame);
-};
-
// A HEADERS frame.
class SpdyHeadersControlFrame : public SpdyControlFrame {
public:
« no previous file with comments | « net/spdy/spdy_framer_test.cc ('k') | net/spdy/spdy_protocol_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698