Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 1225583004: Revert of Add a FrameView lifecycle method that just updates layout, style and compositing. (Closed)

Created:
5 years, 5 months ago by kochi
Modified:
5 years, 5 months ago
Reviewers:
pdr., Xianzhu, chrishtr
CC:
aboxhall, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-rendering, Rik, dglazkov+blink, dmazzoni, dshwang, krit, eae+blinkwatch, Eric Willigers, f(malita), fs, gyuyoung2, jchaffraix+rendering, je_julie, Justin Novosad, kouhei+svg_chromium.org, leviw+renderwatch, nektarios, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, sof, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Add a FrameView lifecycle method that just updates layout, style and compositing. (patchset #3 id:40001 of https://codereview.chromium.org/1217943010/) Reason for revert: This caused ChromeOS's browser_tests failures. See http://crbug.com/507124. Original issue's description: > Add a FrameView lifecycle method that just updates layout, style and compositing. > > Hit testing does not need all of the other lifecycle updates (see attached bug > for details). > > BUG=501630 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198284 TBR=pdr@chromium.org,wangxianzhu@chromium.org,chrishtr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=501630

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -116 lines) Patch
M Source/core/css/AffectedByFocusTest.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M Source/core/css/DragUpdateTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingTestBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelectionTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/GranularityStrategyTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/iterators/TextIteratorTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.h View 2 chunks +3 lines, -9 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 4 chunks +19 lines, -35 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormControlElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElementTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2DAPITest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2DTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/input/EventHandler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/input/EventHandlerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutPart.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTestHelper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTestHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutThemeTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutView.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/page/ContextMenuControllerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PrintContextTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/DisplayItemListPaintTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/paint/TextPainterTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/SVGImageChromeClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebAXObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
kochi
Created Revert of Add a FrameView lifecycle method that just updates layout, style and compositing.
5 years, 5 months ago (2015-07-06 03:47:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225583004/1
5 years, 5 months ago (2015-07-06 03:47:23 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 03:47:54 UTC) #4
Failed to apply patch for Source/core/css/AffectedByFocusTest.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/AffectedByFocusTest.cpp
  Hunk #1 FAILED at 51.
  Hunk #2 FAILED at 206.
  Hunk #3 FAILED at 237.
  Hunk #4 FAILED at 268.
  Hunk #5 FAILED at 300.
  5 out of 5 hunks FAILED -- saving rejects to file
Source/core/css/AffectedByFocusTest.cpp.rej

Patch:       Source/core/css/AffectedByFocusTest.cpp
Index: Source/core/css/AffectedByFocusTest.cpp
diff --git a/Source/core/css/AffectedByFocusTest.cpp
b/Source/core/css/AffectedByFocusTest.cpp
index
a2248889357baa009e03a63bac02d085ea07de11..ee2532cc4237ca73772c350536e5ae9d4f176fbc
100644
--- a/Source/core/css/AffectedByFocusTest.cpp
+++ b/Source/core/css/AffectedByFocusTest.cpp
@@ -51,7 +51,7 @@
 void AffectedByFocusTest::setHtmlInnerHTML(const char* htmlContent)
 {
     document().documentElement()->setInnerHTML(String::fromUTF8(htmlContent),
ASSERT_NO_EXCEPTION);
-    document().view()->updateAllLifecyclePhases();
+    document().view()->updateLayoutAndStyleForPainting();
 }
 
 void AffectedByFocusTest::checkElements(ElementResult expected[], unsigned
expectedCount) const
@@ -206,12 +206,12 @@
         "<div></div>"
         "</div>");
 
-    document().view()->updateAllLifecyclePhases();
+    document().view()->updateLayoutAndStyleForPainting();
 
     unsigned startCount = document().styleEngine().resolverAccessCount();
 
     document().getElementById("d")->focus();
-    document().view()->updateAllLifecyclePhases();
+    document().view()->updateLayoutAndStyleForPainting();
 
     unsigned accessCount = document().styleEngine().resolverAccessCount() -
startCount;
 
@@ -237,12 +237,12 @@
         "<div></div>"
         "</div>");
 
-    document().view()->updateAllLifecyclePhases();
+    document().view()->updateLayoutAndStyleForPainting();
 
     unsigned startCount = document().styleEngine().resolverAccessCount();
 
     document().getElementById("d")->focus();
-    document().view()->updateAllLifecyclePhases();
+    document().view()->updateLayoutAndStyleForPainting();
 
     unsigned accessCount = document().styleEngine().resolverAccessCount() -
startCount;
 
@@ -268,12 +268,12 @@
         "<div class='a'></div>"
         "</div>");
 
-    document().view()->updateAllLifecyclePhases();
+    document().view()->updateLayoutAndStyleForPainting();
 
     unsigned startCount = document().styleEngine().resolverAccessCount();
 
     document().getElementById("d")->focus();
-    document().view()->updateAllLifecyclePhases();
+    document().view()->updateLayoutAndStyleForPainting();
 
     unsigned accessCount = document().styleEngine().resolverAccessCount() -
startCount;
 
@@ -300,12 +300,12 @@
         "<div class='a'></div>"
         "</div>");
 
-    document().view()->updateAllLifecyclePhases();
+    document().view()->updateLayoutAndStyleForPainting();
 
     unsigned startCount = document().styleEngine().resolverAccessCount();
 
     document().getElementById("d")->focus();
-    document().view()->updateAllLifecyclePhases();
+    document().view()->updateLayoutAndStyleForPainting();
 
     unsigned accessCount = document().styleEngine().resolverAccessCount() -
startCount;

Powered by Google App Engine
This is Rietveld 408576698