Source/core/svg/graphics/SVGImageChromeClient.cpp - Issue 1225583004: Revert of Add a FrameView lifecycle method that just updates layout, style and compositing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/svg/graphics/SVGImageChromeClient.cpp

Issue 1225583004: Revert of Add a FrameView lifecycle method that just updates layout, style and compositing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/core/svg/graphics/SVGImage.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Apple Inc. All rights reserved.	2 * Copyright (C) 2012 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 83 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
94 //	94 //

95 // This is cannot arise non-Oilpan as an ImageResource is an owned object	95 // This is cannot arise non-Oilpan as an ImageResource is an owned object

96 // and will be promptly released along with its (SVG)Image..and everything	96 // and will be promptly released along with its (SVG)Image..and everything

97 // below, including this object and its timer. For code simplicity, the	97 // below, including this object and its timer. For code simplicity, the

98 // object protection isn't made the conditional on Oilpan.	98 // object protection isn't made the conditional on Oilpan.

99 //	99 //

100 // FIXME: Oilpan: move this and other ChromeClients to the Oilpan heap	100 // FIXME: Oilpan: move this and other ChromeClients to the Oilpan heap

101 // to render this protection redundant.	101 // to render this protection redundant.

102 RefPtr<SVGImage> protect(m_image);	102 RefPtr<SVGImage> protect(m_image);

103 m_image->frameView()->page()->animator().serviceScriptedAnimations(monotonic allyIncreasingTime());	103 m_image->frameView()->page()->animator().serviceScriptedAnimations(monotonic allyIncreasingTime());

104 m_image->frameView()->updateAllLifecyclePhases();	104 m_image->frameView()->updateLayoutAndStyleForPainting();

105 }	105 }

106	106

107 } // namespace blink	107 } // namespace blink

OLD	NEW